From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Johannes Thumshirn <jthumshirn@suse.de>,
"James E.J. Bottomley" <JBottomley@odin.com>,
Dick Kennedy <dick.kennedy@avagotech.com>,
James Smart <james.smart@avagotech.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] lpfc: Add lockdep assertions
Date: Thu, 17 Dec 2015 08:19:38 +0100 [thread overview]
Message-ID: <5672620A.4060104@sandisk.com> (raw)
In-Reply-To: <1448023037-43391-1-git-send-email-jthumshirn@suse.de>
On 11/20/2015 01:37 PM, Johannes Thumshirn wrote:
> Several functions in lpfc have comments stating that the function must be
> called with the hbalock (or hostlock, or ringlock) held. Add
> lockdep_assert_held() annotations to these functions, so one can actually
> verify the locks are held.
>
> [ ... ]
>
> @@ -2647,6 +2675,7 @@ lpfc_sli_iocbq_lookup(struct lpfc_hba *phba,
> {
> struct lpfc_iocbq *cmd_iocb = NULL;
> uint16_t iotag;
> + lockdep_assert_held(&phba->hbalock);
>
> iotag = prspiocb->iocb.ulpIoTag;
(replying to an e-mail of one month ago)
Please leave a blank line after declarations. Checkpatch should have
reported this. Anyway:
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
prev parent reply other threads:[~2015-12-17 7:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 12:37 [RFC PATCH] lpfc: Add lockdep assertions Johannes Thumshirn
2015-12-16 23:22 ` James Smart
2015-12-17 8:49 ` Johannes Thumshirn
2015-12-17 8:59 ` Bart Van Assche
2015-12-17 7:19 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5672620A.4060104@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=JBottomley@odin.com \
--cc=dick.kennedy@avagotech.com \
--cc=james.smart@avagotech.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox