From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Johannes Thumshirn <jthumshirn@suse.de>,
James Smart <james.smart@avagotech.com>
Cc: "James E.J. Bottomley" <JBottomley@odin.com>,
Dick Kennedy <dick.kennedy@avagotech.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] lpfc: Add lockdep assertions
Date: Thu, 17 Dec 2015 09:59:32 +0100 [thread overview]
Message-ID: <56727974.3040603@sandisk.com> (raw)
In-Reply-To: <20151217084954.GB2890@c203.arch.suse.de>
On 12/17/2015 09:49 AM, Johannes Thumshirn wrote:
> On Wed, Dec 16, 2015 at 03:22:50PM -0800, James Smart wrote:
>> Johannes,
>>
>> Thank you for the time and effort on the patch. At this time, as it doesn't
>> functionally change anything, I did not include the patch. I will consider
>> it if we see additional issues it can help resolve.
>
> As I already said in the patch mail, I'm not sure if it is of intereset for
> upstream, but can actually be quite handy to find something if it goes wrong.
I'd like to see this patch being merged upstream. lockdep_assert_held()
statements are checked at runtime when using a debug kernel, which is
not the case for comments that document locking conventions.
Thanks,
Bart.
next prev parent reply other threads:[~2015-12-17 8:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 12:37 [RFC PATCH] lpfc: Add lockdep assertions Johannes Thumshirn
2015-12-16 23:22 ` James Smart
2015-12-17 8:49 ` Johannes Thumshirn
2015-12-17 8:59 ` Bart Van Assche [this message]
2015-12-17 7:19 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56727974.3040603@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=JBottomley@odin.com \
--cc=dick.kennedy@avagotech.com \
--cc=james.smart@avagotech.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox