Re: [PATCH v7 0/6] samsung: pmu: split up SoC specific PMU data

pankaj.dubey
2015-12-18T08:19:15Z

Hi Krzysztof,

On Friday 18 December 2015 09:57 AM, Krzysztof Kozlowski wrote:
> On 18.12.2015 12:32, Pankaj Dubey wrote:
>> In this series I am splitting up SoC specific PMU configuration data into
>> mach-exynos folder itself, before moving all of them under
>> drivers/soc/samsung/. Also instead of making all changes in single patch it
>> has been broken into SoC specific patches to avoid large size of patch.
>> With this approach there will not be unwanted big churns just after
>> adding exynos-pmu under drivers/soc/samsung.
>>
>> All these patches are just refactoring to keep minimal changes while moving
>> exynos-pmu driver under drivers/soc/samsung/. Support for exynos7 PMU can
>> be added on top of it, in such a manner that for ARM64 build, ARM related
>> SoC's PMU will not get compiled and thus unnecessary increasing kernel image size.
>>
>> This series have been prepared on top of Krzysztof Kozlowski's
>> next/stuff-late-not-split-per-branch branch, and it's just a rebase compared to
>> V6 posted and reviewed here [1].
>>
>> [1]: https://lkml.org/lkml/2015/11/17/15
>>
>> For testing entire patchset on Peach-Pi (Exynos5880) based chromebook for boot
>> and S2R functionality.
>>
>> Tested-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>>
>> For testing entire patchset on on Trats2 (Exynos4412, S2R, reboot, poweroff)
>> and Odroid XU3 (Exynos5422, reboot, poweroff).
>>
>> Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>
>> Changes since v6:
>> - Rebasing on top of branch provided by Krzysztof, after resolving conflicts
>> caused due to Alim's patches for adoptation of generic syscon for poweroff, reboot.
>> - Included Tested-by tags on individual patches as per applicability.
>> - Dropped patches v6 [1/9], v6 [2/9] as these are already present in above mentioned branch.
>> - Dropped patch v6 [8/9] as after Alim's patch this patch no more required.
>>
>
> Patchset applied cleanly with:
> 1. Removal of blank lines at end of two files (they appeared in v7).
> 2. Removal of your tested-by. The author does not provide such tag
> because it is assumed that he tested it before sending. However I left
> the information about testing platform near your signed-off-by.
>

Thanks for taking care of minor nitpicks. I will be more careful, next
time.

> You can find the patches on the same branch:
> https://git.kernel.org/cgit/linux/kernel/git/krzk/linux.git/log/?h=next/stuff-late-not-split-per-branch
>
> I hope I will be able to push it out to arm-soc soon...
>

Thanks,
Pankaj Dubey
> Best regards,
> Krzysztof
>
>