From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752427AbbLRKQw (ORCPT ); Fri, 18 Dec 2015 05:16:52 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:56166 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752338AbbLRKQs (ORCPT ); Fri, 18 Dec 2015 05:16:48 -0500 Subject: Re: [PATCH v3 0/9] phy: use syscon framework APIs to set ctrl mod reg To: Tony Lindgren References: <1450170968-11282-1-git-send-email-kishon@ti.com> <725110094.6UkMkcy8u7@wuerfel> <566FF621.2040307@ti.com> <11176831.mhgJlIuj0S@wuerfel> <56700BC0.7020007@ti.com> <20151215152659.GQ23396@atomide.com> CC: Arnd Bergmann , , , , , , , , , , , , , From: Kishon Vijay Abraham I Message-ID: <5673DCF5.1050603@ti.com> Date: Fri, 18 Dec 2015 15:46:21 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151215152659.GQ23396@atomide.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday 15 December 2015 08:56 PM, Tony Lindgren wrote: > * Kishon Vijay Abraham I [151215 04:47]: >> On Tuesday 15 December 2015 05:25 PM, Arnd Bergmann wrote: >>>>> >>>>> Can you explain here what the conversion is good for? Why do you >>>>> prefer the syscon mapping over a high-level driver in this case? >>>> >>>> phy-omap-control driver was added when there was no proper >>>> infrastructure for doing control module initializations. The >>>> phy-omap-control driver is not an 'actual' PHY driver and it >>>> was just a hack to do PHY related control module initializations. >>>> phy-omap-control is also getting unmanageable with the number of >>>> platforms each having number of modules (like USB, SATA, PCIe), >>>> using the same driver for control module initializations. >>>> >>>> Now with SYSCON framework being added to the kernel, phy-omap-control >>>> shouldn't be needed and it also provides a uniform API across all the >>>> modules to program the control module. >>> >>> Ok, so the "phy-control" devices were really just a few registers of >>> a system controller device that does a lot of other things as well, right? >> >> right. >>> >>> Can you put your description above into the cover-letter for the series, >>> and the merge commit? > > Just to confirm.. Seems like this series keeps USB working and the dts > changes can be done later after the driver changes have been merged? that's right Tony. Will merge this series by tomorrow if I don't get any review comments. Thanks Kishon > > Regards, > > Tony > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >