From: Sebastian Frias <sf84@laposte.net>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Måns Rullgård" <mans@mansr.com>,
linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Mason <slash.tmp@free.fr>,
"Jon Anders Haugum" <jonah@omegav.ntnu.no>
Subject: Re: [PATCH v2] use callbacks to access UART_DLL/UART_DLM
Date: Fri, 18 Dec 2015 17:35:33 +0100 [thread overview]
Message-ID: <567435D5.2040605@laposte.net> (raw)
In-Reply-To: <56743584.50500@hurleysoftware.com>
On 12/18/2015 05:34 PM, Peter Hurley wrote:
> On 12/18/2015 08:27 AM, Sebastian Frias wrote:
>> On 12/18/2015 05:06 PM, Peter Hurley wrote:
>>>> - unsigned char old_dll, old_dlm, old_lcr;
>>>> + unsigned char old_lcr;
>>>> unsigned int id;
>>>> + unsigned int old_dl;
>>>
>>> unsigned int id, old_dl;
>>
>> Ok, thanks for your comments.
>> By the way, should I just do:
>>
>> - unsigned char old_dll, old_dlm, old_lcr;
>> + unsigned char old_lcr, old_dl;
>>
>> ?
>
> The divisor is a 16-bit value.
>
You are right, I was too eager to "reduce the amount of lines that
change"...
next prev parent reply other threads:[~2015-12-18 16:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 15:45 [PATCH] use callbacks to access UART_DLL/UART_DLM Sebastian Frias
2015-12-17 16:02 ` Måns Rullgård
2015-12-17 18:07 ` Sebastian Frias
2015-12-17 18:09 ` Måns Rullgård
2015-12-17 19:14 ` Mason
2015-12-18 10:46 ` [PATCH v2] " Sebastian Frias
2015-12-18 16:06 ` Peter Hurley
2015-12-18 16:27 ` Sebastian Frias
2015-12-18 16:34 ` Peter Hurley
2015-12-18 16:35 ` Sebastian Frias [this message]
2015-12-18 16:40 ` [PATCH v3] " Sebastian Frias
2015-12-18 16:42 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567435D5.2040605@laposte.net \
--to=sf84@laposte.net \
--cc=gregkh@linuxfoundation.org \
--cc=jonah@omegav.ntnu.no \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mans@mansr.com \
--cc=peter@hurleysoftware.com \
--cc=slash.tmp@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox