Re: [PATCH v2] use callbacks to access UART_DLL/UART_DLM

Sebastian Frias
2015-12-18T16:35:37Z

On 12/18/2015 05:34 PM, Peter Hurley wrote:
> On 12/18/2015 08:27 AM, Sebastian Frias wrote:
>> On 12/18/2015 05:06 PM, Peter Hurley wrote:
>>>> - unsigned char old_dll, old_dlm, old_lcr;
>>>> + unsigned char old_lcr;
>>>> unsigned int id;
>>>> + unsigned int old_dl;
>>>
>>> unsigned int id, old_dl;
>>
>> Ok, thanks for your comments.
>> By the way, should I just do:
>>
>> - unsigned char old_dll, old_dlm, old_lcr;
>> + unsigned char old_lcr, old_dl;
>>
>> ?
>
> The divisor is a 16-bit value.
>

You are right, I was too eager to "reduce the amount of lines that
change"...