From: Dave Hansen <dave.hansen@linux.intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Andy Lutomirski <luto@amacapital.net>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Oleg Nesterov <oleg@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
Brian Gerst <brgerst@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: Rethinking sigcontext's xfeatures slightly for PKRU's benefit?
Date: Fri, 18 Dec 2015 13:12:44 -0800 [thread overview]
Message-ID: <567476CC.8080805@linux.intel.com> (raw)
In-Reply-To: <CA+55aFz9XdUP0BQXuq7UuZT1ke-+JVThs-bssMi2sV2xLubHVg@mail.gmail.com>
On 12/18/2015 01:04 PM, Linus Torvalds wrote:
> On Fri, Dec 18, 2015 at 12:49 PM, Andy Lutomirski <luto@amacapital.net> wrote:
>>
>> IOW, I like my idea in which signal delivery always sets PKRU to the
>> application-requested-by-syscall values and sigreturn restores it.
>
> So I don't mind that, as long as the whole "sigreturn restores it" is
> part of things.
>
> Your original email with the suggestion to *not* resture PKRU I didn't
> like. Setting it and restoring it is fine.
>
> I do wonder if you need an explicit value, though. I think it's
> reasonable to say that PKRU value 0 is special. It's what we'd start
> processes with, and why not just say that it's what we run signal
> handlers in?
>
> Would any other value ever make sense, really?
Having a PKRU with the execute-only permissions set is the only one I
can think of. For a system with a _dedicated_ PKEY for execute-only,
this is easy and could even be made a part of init_fpstate with no other
code changes.
But, if we are picking out an execute-only pkey more dynamically, we've
got to keep the default value for the entire process somewhere.
next prev parent reply other threads:[~2015-12-18 21:12 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 1:48 Rethinking sigcontext's xfeatures slightly for PKRU's benefit? Andy Lutomirski
2015-12-18 2:13 ` Dave Hansen
2015-12-18 2:32 ` Andy Lutomirski
2015-12-18 2:52 ` Dave Hansen
2015-12-18 5:29 ` Andy Lutomirski
2015-12-18 6:43 ` H. Peter Anvin
2015-12-18 16:04 ` Andy Lutomirski
2015-12-18 16:56 ` Dave Hansen
2015-12-18 18:42 ` Dave Hansen
2015-12-18 19:21 ` Andy Lutomirski
2015-12-18 20:07 ` Dave Hansen
2015-12-18 20:28 ` Andy Lutomirski
2015-12-18 20:37 ` Linus Torvalds
2015-12-18 20:49 ` Andy Lutomirski
2015-12-18 20:58 ` H. Peter Anvin
2015-12-18 21:02 ` Andy Lutomirski
2015-12-18 21:08 ` Dave Hansen
2015-12-18 21:04 ` Linus Torvalds
2015-12-18 21:09 ` Linus Torvalds
2015-12-18 21:12 ` Dave Hansen [this message]
2015-12-18 21:45 ` Linus Torvalds
2015-12-18 22:28 ` Andy Lutomirski
2015-12-18 23:08 ` Linus Torvalds
2015-12-18 23:16 ` Andy Lutomirski
2015-12-18 23:20 ` Linus Torvalds
2015-12-21 17:04 ` Dave Hansen
2015-12-21 22:52 ` Andy Lutomirski
2015-12-21 23:00 ` Dave Hansen
2015-12-21 23:02 ` Andy Lutomirski
2015-12-21 23:05 ` Dave Hansen
2015-12-21 23:04 ` Dave Hansen
2015-12-21 23:07 ` Andy Lutomirski
2016-06-30 17:36 ` Andy Lutomirski
2016-06-30 21:25 ` Dave Hansen
2016-07-01 16:30 ` Andy Lutomirski
2015-12-29 23:48 ` Dave Hansen
2015-12-18 8:32 ` Ingo Molnar
2015-12-18 8:59 ` Christoph Hellwig
2015-12-18 12:57 ` Borislav Petkov
2016-01-12 13:38 ` Ingo Molnar
2016-01-12 13:42 ` Christoph Hellwig
2016-01-13 10:48 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567476CC.8080805@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox