From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753754AbcALWwV (ORCPT ); Tue, 12 Jan 2016 17:52:21 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:57463 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751568AbcALWwT convert rfc822-to-8bit (ORCPT ); Tue, 12 Jan 2016 17:52:19 -0500 From: Arnd Bergmann To: xuejiancheng Cc: Lee Jones , mturquette@baylibre.com, sboyd@codeaurora.org, p.zabel@pengutronix.de, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, khilman@linaro.org, olof@lixom.net, xuwei5@hisilicon.com, haojian.zhuang@linaro.org, zhangfei.gao@linaro.org, bintian.wang@huawei.com, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, yanhaifeng@hisilicon.com, yanghongwei@hisilicon.com, suwenping@hisilicon.com, ml.yang@hisilicon.com, gaofei@hisilicon.com, zhangzhenxing@hisilicon.com, xuejiancheng@hisilicon.com Subject: Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Date: Tue, 12 Jan 2016 23:51:21 +0100 Message-ID: <5675031.hi9rRCqFXs@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <5694C725.6010502@huawei.com> References: <1452219400-32478-1-git-send-email-xuejiancheng@huawei.com> <20160112083946.GN19803@x1> <5694C725.6010502@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" X-Provags-ID: V03:K0:Hb+QiUQyKdNyBN/tNP8fQvSdfXF520p7Bsry9EIUJs9+R5fqgi2 XbARdHiUMUuFKdmW6bflcEJE2MUKs/w6UWw0U/fRIiWg8VJwNWIZHgd71MOA5lrNosuiV5J oq52XTL2eZzz2dxx451qYv8Zgkga+K1PHhIEc4rbNfQNMFycuBDJINQ9RGQeikT/xf5a07r h1nTHBk0VDYMMZnFWzQ4Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:8Z8ZqGTTdnc=:HmcRlFuIElpzB0U5H+ahwQ O0MD5buJXR4OAgwxP5syiZcJ59xWm5sLwh1vnx4p2YJuiAADIrZ36IIyH0E8SRrf8417XSMdp SScgpqT2ImYV8w5A4Nzvqe1fDD08ZNRzOPhqY6RGifdqMMlP2d1jqM4v8Hog05BQMUE/o/qQy mpoZba5aNbRKAtOmWKss71GoG4ub4hDO0dFx/kQUQ81xbNDrQA3FPw9QF/0OI8vB6Sy99w1bM rW9nFq6n8CT6GNRn+LmsSgba7Zw0GKO8VM05eIKY57oOvDJ4LSM+gAJPtYGfP+QI4/WVgQHog R3K3SwNEMQAtkXgZjcHU360VMebA8t8ESicVxA1XcRKe6Bot+O7tkg6ajml853gSlrEwnFChN ebNqPW7L7A0cCnfpr0DOoA87tpCCI8ywgy4O26L5UgXvfy/Q4Z6u3eKdWQmSCkIN8pQmaOOA0 6P6S5b9q1KlDZrxRia99GMd1AL5I2jknIQjXNyiCnxIm0WueSZd41C+DN8rDkTfJjayJ7ZB82 erNH0zVO08DV1FfW0YEI08gaMJ7lR/FRjrc4qy/Gmf83s5AhAO014KbzllR9zciNuJ3PIp15M t2IP9o0aXnT1UOLD8MmPV6Uy0Fni8logFZtBi9wAj6x1lHKLElKtn0QbqjW0c6cyx5EODAe91 sx8h5nRGaJkDwNLdEYF8c0VcGwkuoeSrK4xi1on7QT7PphylL20wXlayhap5AV0LaVjDu3vfY gahgwppyf3lRUHpS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 12 January 2016 17:28:05 xuejiancheng wrote: > >>>>> > >>>> Not yet. > >>>> Arnd Bergmann and Rob Herring all suggested adding a specific compatible string > >>>> with the SOC name. This binding is just used for describing the compatible string now. > >>>> When more functions on hi3519 SOC are added later, the specific driver will be also > >>>> needed. > >>> > >>> Save this binding until it has more functionality. We here "I'll add > >>> to this later" all too often. > >>> > >> > >> In the hi3519.dtsi file, there is a system-controller device node described like below: > >> sysctrl: system-controller@12010000 { > >> compatible = "hisilicon,hi3519-sysctrl", "syscon"; > >> reg = <0x12010000 0x1000>; > >> }; > >> Do you mean that I should remove "hisilicon,hi3519-sysctrl" and just use "syscon" as the > >> compatible string?　 > > > > Where is this compatible string _used_? > > > >> If I want to add "hisilicon,hi3519-sysctrl" for hi3519. where should I put this binding? > >> Could you give some suggestions? Thank you very much! > > > > If you're not using the compatible i.e. the device doesn't have its > > own driver yet, then there is no need to supply the binding at all, is > > there? > > > > OK. Thank you. > Sorry for stepping in late here. I still think that every syscon device should come with a specific compatible string, so we have the option of creating a driver later on, and I'd like to see a binding document that lists those strings (which I believe exists here). It's really hard to add compatible strings later on, anything else we can work around by keying off that string and adding a workaround in the kernel. Arnd