From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753604AbbLSIYL (ORCPT ); Sat, 19 Dec 2015 03:24:11 -0500 Received: from mout.web.de ([212.227.17.12]:60406 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753333AbbLSIYG (ORCPT ); Sat, 19 Dec 2015 03:24:06 -0500 Subject: Re: [PATCH] blackfin-cpufreq: Change return type of cpu_set_cclk() to that of clk_set_rate() To: Viresh Kumar References: <5674598B.6020000@users.sourceforge.net> <20151219015926.GJ3946@ubuntu> Cc: LKML , linux-pm@vger.kernel.org, "Rafael J. Wysocki" , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <5675141F.2090803@users.sourceforge.net> Date: Sat, 19 Dec 2015 09:23:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151219015926.GJ3946@ubuntu> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:4gB5fA7ramoXWdVZ+0kKeH5ReSKhyUIL+bflHz+8tMswFf8f97l 43SSkhRqiI0OFtVklbdqOXmonw/YLMoW7zjF/CTWkUXg8O6B3oIgQbzF+QFcWLeuDKYYPOp QUDcWNMvK8YPruIbrnWTsLCzQq3+OVgRT9aQ/V3bSo8CeipE/BZU9i63EhkwtcwScmR9WTf wh3SCMVhh7FpRrbs3VwNA== X-UI-Out-Filterresults: notjunk:1;V01:K0:ZSL8uT9Fuoc=:GZDiZjTOGgLpwc5/IBA1IS RL7rxUNgloYH4zB2F71vwBtfVsm5er4QOwegY8oGGlLbfU1Wuf+lLWpKEV9ijjCLp2UgCrpJ7 mygr69/qgtIsfGhCZL/1YAATYb8qFVwAEcrfgBU/j1NifS6F/a7RhnewIFvzYQez4bhBPoMq8 Ay7DCKYG5RoAixRaWzylR28srEAJHbHYlKPHKle8icqG2WcQRRMID5cJu7ESE3MPX0CUQCUZZ LnE/z+O0jkrYuoNOQvRJdDEsqvBj5cKUP944MyxsC51WeLhGKXc9sAbA0oxxiijcpEjMsMGeS 7xrWmR2RvX+Uk4Xv/K+nHg0zlrUeGYF/FN1oK8uRc/6/+BqtvwCUOEq6ZOtjitJ5/BP6gt1Wf sG2JPp2dFxn8ZWqYpp0FKi3LlGKUn5Y7LdKm6DslNBjkZrK91L7omwtRV2ktCtK+ml+81BxC1 h70j+Y/4MSH90aeaN7wuk0GVfLRyWVs+Wf1p/F/3GKnVMCx8/yXwnf7qPzhG69ZIHvZeBmdy/ DXS4SXbxdN1If5LLXgEJOWUAfURZfDMAYTYV7Cao7SwaN7H8lb1aOabv5lgdYNXKYhw5oIaQg YHyjNEvySzjOmjuKdvzMN/me9q8IcziY/ve5sJTC7GrOCg2+7GTdSlSumL1r2awKL3PHCsRGc aW9DabC9lLk6iF1D25ulERrlHnI6Rl/+AZtdSkxEfPBHY7BZ9dnz5Rsk8n+uha/ecIqh9NeAV DAJgPDEFv4UzQVVn0mcpEbkF3FbMg0jMfdlzpNnee8wqJSlem4RVwN+psZ6oHxQ6a5sKPeMLD 3LJg+QB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> From: Markus Elfring >> Date: Fri, 18 Dec 2015 19:43:27 +0100 >> >> The return type "unsigned long" was used by the cpu_set_cclk() function >> while the type "int" is provided by the clk_set_rate() function. >> Let us make this usage consistent. >> >> This issue was detected by using the Coccinelle software. >> >> Signed-off-by: Markus Elfring >> --- >> drivers/cpufreq/blackfin-cpufreq.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/cpufreq/blackfin-cpufreq.c b/drivers/cpufreq/blackfin-cpufreq.c >> index a9f8e5b..2a6f3ac 100644 >> --- a/drivers/cpufreq/blackfin-cpufreq.c >> +++ b/drivers/cpufreq/blackfin-cpufreq.c >> @@ -112,7 +112,7 @@ static unsigned int bfin_getfreq_khz(unsigned int cpu) >> } >> >> #ifdef CONFIG_BF60x >> -unsigned long cpu_set_cclk(int cpu, unsigned long new) >> +int cpu_set_cclk(int cpu, unsigned long new) >> { >> struct clk *clk; > > Acked-by: Viresh Kumar Thanks for your acceptance. I would appreciate if another implementation detail can also be clarified there. http://lxr.free-electrons.com/ident?v=4.3;i=cpu_set_cclk * Do you want to reuse such a function in other modules? * Should it eventually marked as "static"? Regards, Markus