From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933341AbbLSQXE (ORCPT ); Sat, 19 Dec 2015 11:23:04 -0500 Received: from mout.web.de ([212.227.15.14]:58106 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932969AbbLSQXD (ORCPT ); Sat, 19 Dec 2015 11:23:03 -0500 To: LKML Cc: kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Subject: [PATCH] ti-st: Use a signed return type for st_ll_sleep_state() Message-ID: <56758462.1020902@users.sourceforge.net> Date: Sat, 19 Dec 2015 17:22:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:klBITbGoH7BrnfOZuvNjSF6J7JEnXhm26/uIuoWwpjEyeKS+MjG xvCD0mLgUXTR3QVCujrNeDlZ7Mz4hQv3WQFJ//CgSbvZULGD6a4dHmnmE+5Sd1npYnHlRl+ 7Uvxs4RrKlyA6jpot45WI77CtieHY5clJSZe/ZerMjgjxhEnm5eU2v2Y6E6ihEf3iL6ooKj gKuX2j3N+IhvRzX7CQLIw== X-UI-Out-Filterresults: notjunk:1;V01:K0:KJ39xBNb9dk=:1DeVMLQE6yjHTDTc4ljTh6 Er1+c9pCuUyWdrTZKaoqN+wtU1BzZ2tjeHtlUE8FB7zCLW6Zd/hw6SDyWbT5FUBXZNY+ukCBs xx0adzaJ5orv5lcetrv6DGNvWNukt9UwI2YCgBu3XtyOZKuV4QwQbIG6Gaey+FMLeez424+Px 7asgnIE6mfhPy/zeK3llQZXtObxPMh93aOYphV2DsVFrFZ4eDzj/EDXRKYwCrYWCaGAYj/3C/ +6OLjSDPh4ymWXCvAEDGTRWUJ+eWC5OQHRoWrVZI9actMs/zTRCrkazgIrHNKksdd+cleVnty 0EP/b4U1Ff4LcMgKRKmAvlrv6E4y8TEvgNDFR/dRHkxzcI2f0UgKcMTy2BnVsWVOf6Q7QumQ/ i+7n7JQCqMDOigWbZxKlEdP1kCcq+/OvHdNdG8DzIx6C+Za+X49jb7esP4TiVx+JIDN60a+JO EuxUxvYkwE0jsI8u/CAdMVfkyzqrC6IA31jPE3+iC8/z4Q+7dwCCDMy3XEl+c7QbLoT/6kNgr CfxM7bwZHbLTEsdGNdLyaoig5oPBJEIaCVOyCQZJ4fFHWLHvDfkH9mxQyINXRuMma3S98bPfA k1XhAc9pJSnOpoY0GBAEifmN83vN5w96X8G3HGhk9w4yrnCkH6BlU7Ku82rYAQ/EA+Rwwo7aw SB0fIbhMLTDIjP/Iuw6YsYzGBhvCwLVO9mipDbgdcC9xzIIavO8aVd4+U4PPnkwcsFVr3dYyj PZHZfBjikof6K2xppXbpntTgnublOgEAtxLaIC0ktMl397qv51lI/RCm7FCjEr9iuDSbDcekm lT15pku Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 19 Dec 2015 17:15:34 +0100 The return type "unsigned long" was used by the st_ll_sleep_state() function despite of the aspect that it will eventually return a negative error code. Improve this implementation detail by deletion of the type modifier then. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/misc/ti-st/st_ll.c | 2 +- include/linux/ti_wilink_st.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/ti-st/st_ll.c b/drivers/misc/ti-st/st_ll.c index 93b4d67..dacf071 100644 --- a/drivers/misc/ti-st/st_ll.c +++ b/drivers/misc/ti-st/st_ll.c @@ -128,7 +128,7 @@ unsigned long st_ll_getstate(struct st_data_s *ll) } /* called from ST Core, when a PM related packet arrives */ -unsigned long st_ll_sleep_state(struct st_data_s *st_data, +long st_ll_sleep_state(struct st_data_s *st_data, unsigned char cmd) { switch (cmd) { diff --git a/include/linux/ti_wilink_st.h b/include/linux/ti_wilink_st.h index 0a0d568..9604352 100644 --- a/include/linux/ti_wilink_st.h +++ b/include/linux/ti_wilink_st.h @@ -391,7 +391,7 @@ void st_ll_disable(struct st_data_s *); * of the chip. */ unsigned long st_ll_getstate(struct st_data_s *); -unsigned long st_ll_sleep_state(struct st_data_s *, unsigned char); +long st_ll_sleep_state(struct st_data_s *, unsigned char); void st_ll_wakeup(struct st_data_s *); /* -- 2.6.3