Re: [PATCH] iio: add ad5761 DAC driver

Ricardo Ribalda Delgado
2015-12-20T11:25:17Z

Hello Peter:

Thanks for your review! I agree on all your points but one:

On Sat, Dec 19, 2015 at 6:06 PM, Peter Meerwald-Stadler
<pmeerw@pmeerw.net> wrote:
>> + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \
>> + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE) | \
>> + BIT(IIO_CHAN_INFO_OFFSET), \
>> + .scan_type = { \
>
> the driver does not support buffered mode, not sure if scan_type should be
> used to store the number of bits; I think it would be cleaner to put this
> in chip_info

Although I understand your point, must of the other dac drivers are
doing the same and in my humble opinion is very elegant.

Best regards!