From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964990AbbLSRAn (ORCPT ); Sat, 19 Dec 2015 12:00:43 -0500 Received: from mout.web.de ([212.227.17.12]:65186 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933273AbbLSRAl (ORCPT ); Sat, 19 Dec 2015 12:00:41 -0500 To: linux-gpio@vger.kernel.org, Linus Walleij Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Subject: [PATCH] pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup() Message-ID: <56758D34.2070806@users.sourceforge.net> Date: Sat, 19 Dec 2015 18:00:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:7iUiG6k9ztPwnY4rdHIkd6iBCDrIxmTHkVxLLBx35Ht4nIHyfb1 QoVuNVMT1BdTwckHyxTxld/CgfwKT9d8QKNqkGIl26J82XKEx73T/nwUd98mhx22o7/8uOX vQBRXtNAw1A7fcs1nOPRqMafm3oFdDljqV6WPpoTO0aeGLyNxwGWP0q5Tz5phgnNLeyI4Ng yU6NAgANePJaZaoAJmcPw== X-UI-Out-Filterresults: notjunk:1;V01:K0:HENIleduMes=:JlxzTyeMCOMmul57LIaOdy W6SzBE3Q0TSmVanmOYFQ6RARHm047AMSKEXnrpC82JUmZwgRrx87sx+mEDbCO2MnmY7O2NZ7B meQKW3k5ACmdiau5Yv1XzwRPvbcK0adtZh6IuS8+vCFRdjLc9O7eoPAHQEhccQ+ZrPhbombdR fZ8sHw6uJg38s4UFvzkvWIVTOo2HH6K2OypEZGnzsCOD7Br/+BLm5trE76AGxY+dMdr12UG+6 pkBCRygduBcu1zQnhSPVpNGRIz0K8AINtOCS8fXBSdVHWnIZnVMKsUvhImCKK1aYCJofIJ7cv 86oO4w9hfVfNof/+frshGad+rsROSu9VYBoMvQmMwVFrPMWribImZL5yjysNEi8qZ+SKfjTyG EPcv0ddhS+lhcla2D9MjNcEGJnd5RH4oT77Eika7FzOJoLSz6whFZ6QEoPdJj0bkfvxQpe3B8 uoZkwGq6NGX3cbSpItPfD4eSLP/ofywgo7ivCe6vILtcUSo/B8iGfzS/osvFseQ+pLAZqfI37 L4/lROcu5AkUAhBIdKKx71kMymPuX2yKqmNBcLPVqz9G2o47lUNQF0RXp6preBBno1krdjzqR cLwnctwclhFGjewGgyBwxOJ1EkpN3RrZj+AJloET0TtHQt6xyN72rCpPXApJLTk5eoEyWZP3Z DXQwTr6/7f94DUG4qeEwjj3evgridcKr66gxbFyKhcNJxL80eUj9A1iZ/xMr7MFgPR42+VS0p nnN+9aTlFT4FRHK1ob5/Yj90qjcfeaJdP4t63nOy1AH0A2TkQMJbqTl63wFBlkAIssWsQNh+i MG82gn7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 19 Dec 2015 17:55:39 +0100 The return type "unsigned int" was used by the adi_gpio_irq_startup() function despite of the aspect that it will eventually return a negative error code. Improve this implementation detail by deletion of the type modifier then. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pinctrl/pinctrl-adi2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-adi2.c b/drivers/pinctrl/pinctrl-adi2.c index fd342df..4032004 100644 --- a/drivers/pinctrl/pinctrl-adi2.c +++ b/drivers/pinctrl/pinctrl-adi2.c @@ -329,7 +329,7 @@ static void adi_gpio_unmask_irq(struct irq_data *d) spin_unlock_irqrestore(&port->lock, flags); } -static unsigned int adi_gpio_irq_startup(struct irq_data *d) +static int adi_gpio_irq_startup(struct irq_data *d) { unsigned long flags; struct gpio_port *port = irq_data_get_irq_chip_data(d); -- 2.6.3