From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965046AbbLSTh6 (ORCPT ); Sat, 19 Dec 2015 14:37:58 -0500 Received: from mout.web.de ([212.227.17.12]:51858 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752998AbbLSThy (ORCPT ); Sat, 19 Dec 2015 14:37:54 -0500 To: Christopher Harrer , Greg Kroah-Hartman , Lior Dotan , devel@driverdev.osuosl.org Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Subject: [PATCH] staging-slicoss: Use a signed return type for slic_card_locate() Message-ID: <5675B207.2010706@users.sourceforge.net> Date: Sat, 19 Dec 2015 20:37:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:JwdD67NWD7vMt6dG0KHRbJEoFeZKHP/6IH2qZZCpKt6FsxVj4Yx 6w+89nJl/LtFXLy2cTfzNzQfNlg2/FrRUhamuWBbyBkCBfQbDEJlxOrVOOKwSKWE/UeIvaA 5bvQwxe8uc8ehDTRK2y4M7gugNDQoLDjb6UK7jjRKfaHYPhF21zNyRZLZkvXXMuM3EdUjjB TU3fJH0Bn5cmDJz4gdh/w== X-UI-Out-Filterresults: notjunk:1;V01:K0:TvvtEq0slwM=:HDHhxhwyciWORP9mpzWzgo CWNuxnqXDbL9J6QGxpt3w9vJwHwnoVPqt8+VuCWbwLiSLj+sLeqR4A9vrGfJrFggYJSkryb6f 8NWp9LrQoLsI02RisY8kIvrHRiBKM4aN42W8cRct7lY3zCohkEmilHpbZtDkNByHV1SYJQvJO LY6V3OkmgTCjB0w2vFzVNovIgjoA6KeqAhg5DCKjSdEvDv14yclKkqfIfrGvqxzrPuZYL2clD 4qly3g3VspfFmpUiijx4QLdZNj7GsEAdyhFy6eU5TSJyaJtBEqyigHGsyi8P2cZBq7Il9Ua6F MGCaLoeB15oVNJZRdNvVTk8AT9UXeMwvKrFnEnhC4SrgDyseSvMdrmOmoPttDSlpCO/uZb0YS 5YL01P9awVD0Wig4JJQ6EFB2dimrA7qIFYO0NsBFfhMNy+FDq0gi0+gdkoj61qGA+1Kv/cUXs fmEelxxg3LB+UkYTWtuBIk1KX9fswAsXAV+TvOKpKFS7Gx6YprnO5TafXuoe0QnoFm4cWvpSz z311aMV3mnIsGuXm6qdXyIzr4kSDtn7VdacVckdYj464CO6gxwD6gH/dOIZrm/AjtdriaTNq6 2MTxxOSXRe/izgo0+7XprWg9wZ8cMlSCkswzDi7tOvYoB+CP4j3MhFvRMgxvXL5EVKOnw2Enj KeusyKDHbHBnhLBdY2klQxQx+wpUkbapsa5Az0HgFKxMxwEDyeIvDvF2fal/wbAeUrKgP9o2i Z8J1/Ti1RidkAkAxrfRjyDJFlFQz6yvFIFEvk+jEJ+DlnMhmwS4HWUGqry4Uh36CaA8Mu3yB9 H13/dFh Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 19 Dec 2015 20:30:39 +0100 The return type "u32" was used by the slic_card_locate() function despite of the aspect that it will eventually return a negative error code. Improve this implementation detail by using the type "s32" instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/slicoss/slicoss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index b23a2d1..9ba0e4b 100644 --- a/drivers/staging/slicoss/slicoss.c +++ b/drivers/staging/slicoss/slicoss.c @@ -2953,7 +2953,7 @@ static const struct net_device_ops slic_netdev_ops = { .ndo_change_mtu = eth_change_mtu, }; -static u32 slic_card_locate(struct adapter *adapter) +static s32 slic_card_locate(struct adapter *adapter) { struct sliccard *card = slic_global.slic_card; struct physcard *physcard = slic_global.phys_card; -- 2.6.3