From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933323AbbLSUPg (ORCPT ); Sat, 19 Dec 2015 15:15:36 -0500 Received: from mout.web.de ([212.227.17.12]:53025 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932724AbbLSUPd (ORCPT ); Sat, 19 Dec 2015 15:15:33 -0500 To: linux-usb@vger.kernel.org, Greg Kroah-Hartman Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Subject: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep() Message-ID: <5675BAE0.2010304@users.sourceforge.net> Date: Sat, 19 Dec 2015 21:15:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:3WWSxUhRWSY6OvtkJE8O3SlhxRYHgnGxbpGJzaS6kbn5mofZO5P cVJKN4VQdGNRiRTEiAXkNH1dBugInngKMgmszCm3CNe9FYmhMlZXlvKDi9TTEehr8LOAtrB 9E69ug96qbJPpq7R6O0RBBeANrQrWpj+SXC5antU5MEHxfEwKBoQcQ3s+5OOjQ/dtBYNKMg iGgUY3RLO5huYqlflyntA== X-UI-Out-Filterresults: notjunk:1;V01:K0:rbB8cwyWx8k=:k+tZZ8LB/xt6gco0ZtS8bm rnpY4AGDLfMmXj1lAEMmpUBEQmXecG4HQwpdcZ5S6bQ6xHHc+wD90k70dzvExVW+yT628vqGk psKzq3oyHrMgbNU3FT7TSBosXFCsADhYn8DLh+Lv1+/yD16vC36CogfY0IHpAS2K/eYpZKLal RqnoikdLYMvhIg1dXjGaNG1JL4ZX3EuzWaYe+M/5m2NAJqZKq1Qt1rTA0Pq9w5Gid4wbREB7y rYhi5MzSxgmvh7M4hbE4L2lvG3drCFk9oiydX6siLLgXVNe+yyx4u/Fn0k9jr1xHjvnxuBtvZ dQdNHe5gZaacHbDAycOhoFoYVOyMlVOj+rQypIFrlqoShwLpRV0Xy0r5+ooSTEvRsmnu2swM+ c6e05C+7lpBaxogm3hMzf53RtnXfxQKPjdaWHNRDrFqXwHeUkvGahAlRghfzZLV/c6Bh9X9ST b6jp4nk8yOxlnZpDgctEmH47o0WYlbvQzhpXWdoHM2rjjWtPlXtBVp+dO8tcHXhg5/uzvYMr9 rINq4goDZ6DcpRCV2R614iMgOga9YaHKYXhz0I1fDV7uMJ5LAxqwMOWz66iRFGe7SEjN8NJ96 oVr9gVKYno3efr+i86HGy6A2g5LDzb+gxhZFH/GyoLeB7r5rVSUBBXVq8saiXASvZ0Xcp9zsH Q2dau4DEuXY4MmuDW1VWhiQdhSfOonyqbs67TdKqEXbzxgOIcD6w1phmuFv0ZukmQASTfLDR+ i5K5mD8Sks4q2InIaqAZLs+TTnL/FDx5x4yqKYghAt9/lf1bXzrbCcXTVOKsGjYlBVE5Dlzn2 LopkEL1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 19 Dec 2015 21:10:20 +0100 The return type "u32" was used by the fhci_create_ep() function even though it will eventually return a negative error code. Improve this implementation detail by using the type "s32" instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/usb/host/fhci-tds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/fhci-tds.c b/drivers/usb/host/fhci-tds.c index f82ad5d..c1ae172 100644 --- a/drivers/usb/host/fhci-tds.c +++ b/drivers/usb/host/fhci-tds.c @@ -149,7 +149,7 @@ void fhci_ep0_free(struct fhci_usb *usb) * data_mem The data memory partition(BUS) * ring_len TD ring length */ -u32 fhci_create_ep(struct fhci_usb *usb, enum fhci_mem_alloc data_mem, +s32 fhci_create_ep(struct fhci_usb *usb, enum fhci_mem_alloc data_mem, u32 ring_len) { struct endpoint *ep; -- 2.6.3