From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965116AbbLSUki (ORCPT <rfc822;w@1wt.eu>);
	Sat, 19 Dec 2015 15:40:38 -0500
Received: from mout.web.de ([212.227.15.3]:61909 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S964956AbbLSUkf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 19 Dec 2015 15:40:35 -0500
Subject: Re: pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup()
To: Dan Carpenter <dan.carpenter@oracle.com>
References: <56758D34.2070806@users.sourceforge.net>
 <20151219201213.GP5284@mwanda>
Cc: linux-gpio@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <5675C0BB.9020204@users.sourceforge.net>
Date: Sat, 19 Dec 2015 21:40:27 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <20151219201213.GP5284@mwanda>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:GifXAS/04x+y5Z1N1NCncSVJVfmRPv9H2UhJ5boEPF99xqReJWm
 3FwQxdN3KPYUm9LIHgvEbW0VwiYgkHOhjvd+XuYO4s2zcuOD+AK6Wixvj5UxlU9TygKuoF5
 5rTcdLMiHJbYVvtHOYYg1wpe6DPWNae0ClyZgSgIuIYyJVSepgTGCjGOAxCYpxCDZOVPWFV
 Rdz6xRQyUgdhHc2FnET9w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:08SMiEwg5Y8=:2f3ua6cgrYZzLI40Hg75Va
 8csQtW4R84f35uuoJS8Wu0bScDvBMoLDQammSJAoPGiDG1uDFUuDUt3tFG3PTy2w0Z/qh+MRg
 WFGUBXUfSkmq7UAjoQ9b78Gpxiq3BSvvKBJuofbCLojqQ8Rry/SCqV4wcUKH1iMQ+WjUd8SVY
 2rJB/2HEul8hlt+1e9xEpZeOZcygwoB3/grZH4AW1gtvLifkOOWc/jhlxB/v1su/eVOo3e2/t
 KR3NfYQapEqAT00hjxPNWdWPjo3xNsdsQdFpDrUOSRt6o0tKZRGabzqItAZKgM0os8bxkbdhh
 Dq32eLzmewwIsyXkbtcNXyrCKduqIP4PbnYapFJtKAUqzJ53gUBGwRL5Fz14MQOheRI1D8Kgs
 11cop2RYoJVQKKdqB/+UIzZZjfDkT/yixqZWlh4492FXmrtwD44kzNvkoTevmt19Dj3jSy4z8
 OtcP3iwCHnHal0IvXrFRd3o9LvzO3k9MN/vrQ4lBTXA+6twKocYKPMCjbdNe/7zRgOK2OdM7b
 xaAprGJ2hNh0TpkK4Oc3JQkOtogRUu77GKUggU1l+9qa9tvhZGfx1PRn4uTaNEuYDMRNR+VIE
 C7Y00prFerog/Iq0V5gjnoFm/Ftr4vvHZjfeXOpuk8r7T6K6d+1370hUVfvYA/L5AalW8tkpr
 jKNPvqOpxLb0atWj5xb/t2m3S475DI0RMzTUB+L9CuygRNPjXMRCnL4MwQ/TskDZke44O2BZj
 SwCLu5lb8uA/xgXQndvco1x4AZeXX9dJ306Tps+OX6kRV7E5LUa8TXLh1nHHbqbREdDqkh7fO
 7zRHBft
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> This introduces a compile warning.

How do you think about to show the exact message you get?


> These functions are supposed to return 1 if there is an IRQ pending.
> Change the -EINVAL to 0.

Is there any more source code clean-up needed around the comment "FIXME"
in the affected function?

Regards,
Markus