From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933307AbbLSUqd (ORCPT ); Sat, 19 Dec 2015 15:46:33 -0500 Received: from mail-lf0-f53.google.com ([209.85.215.53]:34189 "EHLO mail-lf0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933083AbbLSUqb (ORCPT ); Sat, 19 Dec 2015 15:46:31 -0500 Subject: Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep() To: SF Markus Elfring , linux-usb@vger.kernel.org, Greg Kroah-Hartman References: <5675BAE0.2010304@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <5675C222.6080707@cogentembedded.com> Date: Sat, 19 Dec 2015 23:46:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5675BAE0.2010304@users.sourceforge.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 12/19/2015 11:15 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 19 Dec 2015 21:10:20 +0100 > > The return type "u32" was used by the fhci_create_ep() function even though > it will eventually return a negative error code. > Improve this implementation detail by using the type "s32" instead. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/usb/host/fhci-tds.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/fhci-tds.c b/drivers/usb/host/fhci-tds.c > index f82ad5d..c1ae172 100644 > --- a/drivers/usb/host/fhci-tds.c > +++ b/drivers/usb/host/fhci-tds.c > @@ -149,7 +149,7 @@ void fhci_ep0_free(struct fhci_usb *usb) > * data_mem The data memory partition(BUS) > * ring_len TD ring length > */ > -u32 fhci_create_ep(struct fhci_usb *usb, enum fhci_mem_alloc data_mem, > +s32 fhci_create_ep(struct fhci_usb *usb, enum fhci_mem_alloc data_mem, Should be just *int*, I think. [...] MBR, Sergei