Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep()

Dan Carpenter
2015-12-19T21:04:33Z

On Sat, Dec 19, 2015 at 09:55:02PM +0100, SF Markus Elfring wrote:
> > Just make it an int.
>
> Thanks for your suggestion.
>
> Will any more software developers prefer this data type
> at some source code places?
>

Use s32 if the hardware spec specifies that you must. Otherwise prefer
ordinary types.

>
> > The caller also casts it to u32...
>
> Do you want to get rid of similar casts in affected functions?

If you want, that would be great. I just enjoy complaining generally,
though. :P

regards,
dan carpenter