From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965086AbbLSUzO (ORCPT <rfc822;w@1wt.eu>);
	Sat, 19 Dec 2015 15:55:14 -0500
Received: from mout.web.de ([212.227.15.14]:64937 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752982AbbLSUzL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 19 Dec 2015 15:55:11 -0500
Subject: Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep()
To: Dan Carpenter <dan.carpenter@oracle.com>
References: <5675BAE0.2010304@users.sourceforge.net>
 <20151219202706.GT5284@mwanda>
Cc: linux-usb@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <5675C426.7040602@users.sourceforge.net>
Date: Sat, 19 Dec 2015 21:55:02 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <20151219202706.GT5284@mwanda>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:3xiONgTkrLmVF/n0HmfjcC1lGtBJq6L2NzdLCru2c6G4Rk7bCXw
 Gib/81v1KMYXREk9+uRem0wfLMgHdTFEAf0Qqc0pEOZxro204Z5AMZ+16fST54DpBK2L2UG
 yeGep7vcrQcOdRknGtUOGbwu+82F6pZ/3HsBsuf6xBvp9J2IaMbn7WVxMBB7hxAa6yOfzTU
 fhtlEkx56gQcI3rKnq3Bw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:pmP9rFUD1qI=:GQEyVtJQp33xwjx/mydwL0
 es//wcEns6sv6NZhefNBY+agi1PuQK6SJYd3EpDvLNa/zd1O13kF/0zXeao3UVXQijuY6ttMa
 7DxhTWCwsUaTna1BIKD4tmCo2U9QRkyC3zPTYuU02bchjxOaObrZo1iz1KrGTDXuSEyMk6Pqk
 N66NPj6FMRN0tU6fTRiSFul8ONR0013ifQubpKHXrtYRBoklTie81NkvArnzNASvcQG+/xae+
 OzU4A0wRr84WnfO/jamTb1jdSJ8F60dSek2CM1pL4hhbMG5pPJO99CU4ORZrBx3Uvk6dh2igN
 ipLG9EN5E0JwgDBlrq1nptaV5V7V5X2JfCgjwutg4MJbY72ZRgs48RdHqFKtfLFnNlyxatj5G
 PYdJnPvC27QPVV0kDhQBj1KEImq45GEAL3gWoim4xW7G+LPuJj9mTEOUQIpBnt+gZfAVNrA1f
 QWY0mqlSJKK2yyFkxFOvWjUovyXce8Ctgi4WpcPLJPgBtAzcvzIFuD57V7m9/O9jagEU4QxxB
 2ifSTl0OiTYIflYrNQvVHWz3Dni5yYAuhP+dzjfhljTmQ4WE+t/+lLTeTHDZPNLUNNNcycaUi
 mdD4VqDmP7OVoIy3sLZ7ymeIJTaMFOJ1N92llqLmycKQdn8mjs2lPSHfjsnCnELuUv9n/QZaU
 2uPit/ozyJFlqleGxDR8kXQhbpjFUOprvr0hKQd+ybl5A/r3HDG3lbQNsJ/yEm1Y74xqtJbxQ
 KkwyDBZ4LIwqT9TdQpuRkLR3LJHDE3yZWlQsWu5xuFoMkFWM4VAQFDRJ7FULzenHr/j4atAQn
 DEXyjW0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Just make it an int.

Thanks for your suggestion.

Will any more software developers prefer this data type
at some source code places?


> The caller also casts it to u32...

Do you want to get rid of similar casts in affected functions?

Regards,
Markus