From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933345AbbLSWUp (ORCPT ); Sat, 19 Dec 2015 17:20:45 -0500 Received: from mout.web.de ([212.227.17.11]:55100 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932727AbbLSWUm (ORCPT ); Sat, 19 Dec 2015 17:20:42 -0500 Subject: Re: pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup() To: Dan Carpenter References: <56758D34.2070806@users.sourceforge.net> <20151219201213.GP5284@mwanda> <5675C0BB.9020204@users.sourceforge.net> <20151219204501.GV5284@mwanda> Cc: linux-gpio@vger.kernel.org, Linus Walleij , LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <5675D831.2070307@users.sourceforge.net> Date: Sat, 19 Dec 2015 23:20:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151219204501.GV5284@mwanda> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:fEUdOx3uJHhSNzK7B/zQo/Ky3xMtewB3FN1y17CwY1YIsujgRqN 2dAdXIAg7LxqVFqimhLVnQ0yF1t5BIQe0WWy6whgex/L8DJqttoreYf88U9NkB6dJulteLo nGZtiun+v7gvJaHDltQOfkoc4Al5hMaCZelxUkXTo1gCmX1NHYSR38A1sGHVGkMC/rK4GqO EkRV8xcUfh2MI+loC1Pdg== X-UI-Out-Filterresults: notjunk:1;V01:K0:yK068H3xo2A=:LJ6JPZ+IgqWjpKgBzq96C1 KpTVZwrR0cWhM/B80ClRop2ifKbUQL5b9/JNUUxPJ9dHsH31MLcFgkU8FW8nYm3NQc43N9BhP Z2r7S3Bi92bgfg7nCrHS16FrwKxFTrSNYDs9RebuJ0qe3miwNofjAFccAfFziZjXMcIlA9/vY I8LbpeHAV5+vGWrQhz/W9pbHMIERfGekCJqtQXylFpMc75sZr0cCfy81bYJzS9s50a88nJk/V iOIypyz3cNa31bI+Rk5SnHRqw9ja6WcG+z0l2p4vDyRCj+72XqU19z77oNxsGPOMBnk7Idnkg unZxcAVEdX/AKx6fyolkrRfdzc+04VcFRVp94aiE6VkGC2zdu6HEPa2Cp3qDWXFvJO19cLrzo HgaMtf2klFbFpamLXX21cJ2iHllVp2jz6i9/0Go5bSgIxk30P1c2b0N8kgIhfDQwAAStc6FZ9 KT8pRw+8fwYVgRJSov44F7rnwTZLjU8ueJQGHBsb0WvXKCi4dXGVT3AFsOxihkwnNx35Ataxn hj5b8luAMQcXfySpZzZXqtHNfH6gWGdBmqcc3ZNYRlnhc/tIJKlcXEFP3Quriw3Lf9JA2tzzw ggvEfPKR82jVIkfzPphaBb732j3urLrnz7bux7ErxAnFbfBi9rWW74AugKb82dRFW0jWHejtj 1csTGxfSYEGPwRVBXXyaAFUlivahQU9daTzqEIu0hPX2KknfUTU+8qDxfWriI87g9L8peo+Ic PAwnj4bE2gsf1suMj6FaZjoPkowF56KXwBmM2DWpQnEPXcRmiUptkpYqUrUDr7FKTL5ZYtfxc wQkigJ3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> This introduces a compile warning. >> >> How do you think about to show the exact message you get? > > I can't actually compile it myself. It seems that I can understand your feedback also a bit better since I received the information from a background process like "kbuild test robot". Will it become acceptable to adjust the data structure "irq_chip" for the variable "adi_gpio_irqchip"? Should I just skip my update suggestion for this specific source code area? http://lxr.free-electrons.com/source/include/linux/irq.h?v=4.3#L320 Regards, Markus