From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932405AbbLTHAq (ORCPT ); Sun, 20 Dec 2015 02:00:46 -0500 Received: from mout.web.de ([212.227.17.11]:62261 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751402AbbLTHAp (ORCPT ); Sun, 20 Dec 2015 02:00:45 -0500 To: xfs@oss.sgi.com, Dave Chinner Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Subject: [PATCH] XFS: Use a signed return type for suffix_kstrtoint() Message-ID: <5676520D.2060806@users.sourceforge.net> Date: Sun, 20 Dec 2015 08:00:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:pM0sQT0G1ytxhW7JbZKo8mQFuwQYhV79PCKvYyElaVl+UvxJ4+8 GWEQEcRXl9f6W3W/vJH2KT+L0ZnrjNSw2qSPNnr3psjWFcMyhQEa65nNjWd8oOFfbDG/IMi Vsk3CkEeysulRVc6DrHQdPR0Zo3beFSljvy/RwunFUorN2W2PCGL44U3Xp+T42mj8c2etks gWAtsP8ksfucl3+tYotNA== X-UI-Out-Filterresults: notjunk:1;V01:K0:PldIV6vWxzA=:3kAQhXVVDq+1mec+y0eCWY 1s9L4qcte28YRG+FhqmjFQ6qCpiT07sEJv4lhaJcfh+OFrncZXzchYtfGC4G8tQ1qioKWxwe7 MtiZMNihDORNHbR9qmUByYSnPPoXO9kZuk1ZomE1q98n6tA0XJKrYFRLEyJ5f2Z/DmsiEADnU gbKakw3nthE079OZK1nWzVFotcB8g2BTNPRrDP1K/OmuWFZ/Axm3Yre5cF/8ybmO+m2s+jyNP 41EhznB/A0BJN9iExrsZNnu97wLT5PtaXKUZwRpJvVxspuRXySdA59rPKFbFwyax4GB9tKzBS ZpxZv+TSSeuNgSRtOIuu9qi5f0QRcxEEXVvFgdD3tqVaRG+RUCFp57a3fdHWmDOyG8AFns1c/ +oN0KJj01qu9QSXxnf9Eu3XKBW3iv0VP9SEmsmSfsKfMPcL/fzHUbJZxKaB1Jr8RLyHIKQhcl 1IOtR5XFGSbRGojavkDRL+NmVL8ogCgTEHgn8AzfGO4kN9YahzAA1s+SodBw1elu9nNygKL7z bqY6FQEkiLPZs0Po+whQVZv2abFY8ukzayNGRMUUuhwJsvq0KQNAcdPHkp1WzfLZQpByvLjys rxiezYNowjFbmgWN1a7GM/nkcsujTejaN8Tfht0d4jXlS0bt+vD4sdLE620Rnde6U87rGOH14 Z1Yz39erYJgnWu1oUZIze9gfs4JmwNmZutBXsvItmAzBSM6geKlv4jf5DKCZkCNn1DnBn+6kC iUMc/OVVpEmzMyz+T+EAixFbmqmcLVWqNOY0umXepo62xEHat+AJbuEi0EM2Ro1ox1pMcKCZG P0KNgsq Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 20 Dec 2015 07:56:36 +0100 The return type "unsigned long" was used by the suffix_kstrtoint() function even though it will eventually return a negative error code. Improve this implementation detail by using the type "int" instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/xfs/xfs_super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index 436b6ef..59c9b7b 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -137,7 +137,7 @@ static const match_table_t tokens = { }; -STATIC unsigned long +STATIC int suffix_kstrtoint(char *s, unsigned int base, int *res) { int last, shift_left_factor = 0, _res; -- 2.6.3