From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932948AbbLTMsd (ORCPT <rfc822;w@1wt.eu>);
	Sun, 20 Dec 2015 07:48:33 -0500
Received: from mout.web.de ([212.227.15.3]:60972 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754407AbbLTMsb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 20 Dec 2015 07:48:31 -0500
Subject: Re: [PATCH] posix-clock: Use an unsigned data type for a variable
To: Julia Lawall <julia.lawall@lip6.fr>
References: <56766488.9050402@users.sourceforge.net>
 <alpine.DEB.2.02.1512201208250.2067@localhost6.localdomain6>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Richard Cochran <richardcochran@gmail.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <5676A399.4080007@users.sourceforge.net>
Date: Sun, 20 Dec 2015 13:48:25 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.02.1512201208250.2067@localhost6.localdomain6>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:AlWNf4fxLjPDY0qxHqCCDfS4najF4OAnODCjwzP8I/MTRA+C60f
 SzJaQH6Bgul2OoEV9csn+d/YjgPpW2/44sQ88o/isy+ppz1qtY8LeUGbkHDANX1DGPtLfG2
 jNHeQV/ckQ0n0G0AOLYSZbYQz0jgxxkMGOdp+TJKSJueL5qCzJgW1XZZ4P5dhqfQ6wmtu/W
 VcsN8k33FW5dhfNYVa9wQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:+B34NoIVTtA=:jfVUMjJ/uY7dMz2Z/cWEw4
 XEeNDV+LwgDs4V1Vq1eK9Kxda3C1X2MNxvXKcUiTMo4qsu+50+S2FjuXws/mW5Xp/ojfLxDL9
 ND1smo7L3EAJHj3kIZ/2SaQZyN6S91ga33cY6FcZBXjWmmoDK/dF21J0gcrjgIL3zADQ/drc7
 xj7NqRGEQ/W4CiX/WTbEYnF6+dLK3aLolLIcqwyhQAU3on0zE1ElQZyabUuni3uPmBLI6Q/OP
 OCKgmJPhYRJWmgFJE/dZT9v+IiKAjvy433izW20RP82F2RD/xgQZFxUVXPB9WICJWRoEG45wi
 KuEL1TxHH8BbGXhJZhCywwWOgtlXgJvuRphj2gPBA8gl0Lq7myXc4wSK40US0D5w5uChNn7d4
 LjegTfY7wSuNZKMqzsMQ1RWZGFFTDpTE7WGZr0lpgJ0S+TIQuWglBzyCAX7UBeN2ZzJXgtBgd
 93SZ25NXeUahCAsI6TWo6AR4XlMbzS6lp6XMJ8Fo/Xa8Yjzpi02XgwNKtma3ALkFURpHK7PwT
 YDS992WxWV6Pk4SenyLkUz0sRAV+4kiRjPeBDxnO1Yky7vpdK4XV44gu7NXTHpcAN1+orlJrh
 NEJkOHUy/qmGGLXvHWIAxJWlL4dBkuJoQgiof/Tzg3obpngYKft9XvHmchF7jrBzys4IKjXgz
 uShkqUQLRRDQMwBrNd9iQcfd1qYUxSb7YI7d74ZZjP88YOUWRJrK1kyWnhZy72uLvgqavpWdu
 A48BKO51oldMxUaBNUiKGaQDX9nVz+credkaUfkL1jvZySxrCRJpY1bDUVylap74nszRnY7V+
 meZyGK3
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Reuse the type from this poll call instead.
> 
> Why use uint when the function return type it unsigned int?

Do you prefer to express the type modifier once more there?


> On the other hand, why is the function return type unsigned int
> when there is a return of a negative constant?

This implementation detail can trigger further software development
considerations, can't it?

This is a general issue for the exception handling in several functions.
Would you like to improve any more source code around it?

Regards,
Markus