From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754366AbbLTNIM (ORCPT ); Sun, 20 Dec 2015 08:08:12 -0500 Received: from mout.web.de ([212.227.15.14]:61473 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbbLTNIJ (ORCPT ); Sun, 20 Dec 2015 08:08:09 -0500 Subject: Re: [PATCH] posix-clock: Use an unsigned data type for a variable To: Julia Lawall References: <56766488.9050402@users.sourceforge.net> <5676A399.4080007@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Richard Cochran From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <5676A833.4090700@users.sourceforge.net> Date: Sun, 20 Dec 2015 14:08:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:T6tUz1HRxfvbdx7F46EGKmrfk3tOUlwrJ3ASCtD7062P8v9b6nY dbqNrjLMlmHsq8bQtDMlL/fAr5yNE7bASzcIQgo3kbs5Uj+Jj7Ewu9eGfKfDaYkxEpSEI76 KyfrvKX79iCoW1wIACM1kM4yz+QZIoE2kHEdS5Hd7kuseBrHKAJ2CKbWBl3LrFL7Tg0KY2X rccvZAjnyNGHIJraCO/KQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:wTm/eHSI6gU=:9bln6Q7PIPHN6ZpFaHcy50 suwx3HRK4oaPyJEqaUdtIAKMP7dMfq/TBCGVa7Tf/JtFCE6zKxn6cfSO3p/FS+oVDy/aEXAYL lG/8NGJhPmjInFIGUAWwD3yswOdzfifaJmd9AoLIPl9GlgTC2ASSUEDSKNNeh5/J5EdgotokS dK/m+i0R8Nsclxft1vAki63Vh8vfdXd/O6U+yW16i+AYY0nhOGqAwzvlQa8a37oE5pdggPP6j X/rKiXhB34/xc0OtmR8/Oct+rD4025lIwtwhSlAshd8a+apvhDIgI4yNO3TbWVTTZRbvi31/e DSQjJhB65g/61FqaaKnMXhVPSxO7bBwMFjeyeA3wEe5Bu5hga6fgV0Rrxnx9SADttCNSqBJ56 OtBMNySaKyNBS9trKOXX7EHZIwbaStN74nFBWSnb2wkEO2TsRKB/rXyjKN0CrK9bb5KAKeF/K 63rMZ4IhxS+B5ifAZ/NT9aaAlsbx6UbAPhJN06pGyYQg/2IqdiEkyLt7llSMHAIAu2y4HpQ/w sh5rziOQauf85jdXVUYdL1DtfRoMS+IJnp1puEt86OS67IS/On7UdsK+fyA2UX1BeTgjESYRn 8m8KMZtt7jGrPupktWIkKOytIA2hf9lfxpzjaBR083BHez4PBMhs9xf/zVhCwNebaIoHdv2el EPsyXUxiLZHBa437awIqnMsQyHE89LTJIBfKMKPfrim4uNAcF9reioqf1tET200f6Pm935S4c Y8AK6WU0qT1EqRFAqK8SiBeBt8N7yc+sTi0UJDsY3q9ltysobB01w1bz9SLlPjOKI+VWvY7Ht zZCJX/K Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>> Reuse the type from this poll call instead. >>> >>> Why use uint when the function return type it unsigned int? >> >> Do you prefer to express the type modifier once more there? > > I don't know what the sentence means, Can it be a matter of taste if the key word "unsigned" should be repeated in such an use case? > but I think that the type should be referenced in a consistent manner. How do involved software designers and developers prefer to achieve data type consistency here? Which kind of naming convention will get priority? >>> On the other hand, why is the function return type unsigned int >>> when there is a return of a negative constant? >> >> This implementation detail can trigger further software development >> considerations, can't it? > > It would seem reasonable to address all of the signed/unsigned issues > related to the function return value at once. Would you like to extend another evolving script for the semantic patch language? I imagine that the general issue around the exception handling will cause too many software development challenges to tackle them "at once". Regards, Markus