From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: cw00.choi@samsung.com
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-sh@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v5] extcon: add Maxim MAX3355 driver
Date: Sun, 20 Dec 2015 20:15:00 +0300 [thread overview]
Message-ID: <5676E214.2040009@cogentembedded.com> (raw)
In-Reply-To: <CAGTfZH34rfMfjsAFgyPeNue74-5iCi6ZwrdN26_jwOXE6R=hwg@mail.gmail.com>
Hello.
On 12/20/2015 05:31 PM, Chanwoo Choi wrote:
> This patch depend on GPIOLIB configuration as following:
> I modified it with following diff and applied it.
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index ba4db7d..3d89e60 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -54,6 +54,7 @@ config EXTCON_MAX14577
>
> config EXTCON_MAX3355
> tristate "Maxim MAX3355 USB OTG EXTCON Support"
> + depends on GPIOLIB || COMPILE_TEST
If it won't compile w/o gpiolib, what's the use of COMIPLE_TEST?
And no, it shouldn't depend on gpiolib. It has empty stubs for the case of
CONFIG_GPIOLIB=n. Obviously something is wrong with the GPIO headers, I'll
look into it.
[...]
> Thanks,
> Chanwoo Choi
MBR, Sergei
next prev parent reply other threads:[~2015-12-20 17:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 23:17 [PATCH v5] extcon: add Maxim MAX3355 driver Sergei Shtylyov
2015-12-20 14:31 ` Chanwoo Choi
2015-12-20 17:15 ` Sergei Shtylyov [this message]
2015-12-21 2:38 ` Chanwoo Choi
2015-12-21 11:01 ` Sergei Shtylyov
2015-12-21 19:38 ` Sergei Shtylyov
2015-12-22 1:13 ` Chanwoo Choi
2015-12-22 11:15 ` Sergei Shtylyov
2015-12-23 2:17 ` Chanwoo Choi
2015-12-23 19:56 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5676E214.2040009@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox