From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751576AbbLUCiu (ORCPT ); Sun, 20 Dec 2015 21:38:50 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:53858 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145AbbLUCir convert rfc822-to-8bit (ORCPT ); Sun, 20 Dec 2015 21:38:47 -0500 X-AuditID: cbfee68f-f793a6d000001364-05-56776634daef MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT Message-id: <5677662C.6060409@samsung.com> Date: Mon, 21 Dec 2015 11:38:36 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Sergei Shtylyov Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "myungjoo.ham@samsung.com" , devicetree , linux-kernel , linux-sh@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v5] extcon: add Maxim MAX3355 driver References: <5948633.my3nAG6hRz@wasted.cogentembedded.com> <5676E214.2040009@cogentembedded.com> In-reply-to: <5676E214.2040009@cogentembedded.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsWyRsSkWNc0rTzMYPlFJov5R86xWvS/Wchq ce7VSkaLy7vmsFnM+TOF2WLRslZmi6XXgUpuN65gs5gwfS2LReveI+wWZ1bdYnfg9lgzbw2j x+W+XiaPB1P/M3msXP6FzWPTqk42j74tqxg9Pm+SC2CP4rJJSc3JLEst0rdL4Mpo236FqWAP V0Vnw2amBsa9HF2MnBwSAiYSjdPvs0PYYhIX7q1nA7GFBFYwSpxaY9DFyAFW0zvLoYuRCyi8 lFHi8J3JYPW8AoISPybfYwGpYRZQl5gyJRckzCwgIrF03yZ2CFtbYtnC18wQvQ8YJc79fMQI 0asl8Xr+AbBdLAKqEm8/HAWLswHF97+4wQYyU1QgQqL7RCVIWETAQuJu4yIWkDnMAt3MEh+W vAJbIAyUODlvPQvEgpWMEj9WrgEbyilgJHHjxAc2kISEQCOHxNdDj5ghtglIfJt8iAXiM1mJ TQeYIZ6XlDi44gbLBEbxWUh+m4Xw2ywkv81C8tsCRpZVjKKpBckFxUnpRcZ6xYm5xaV56XrJ +bmbGIHxffrfs/4djHcPWB9iFOBgVOLhtVQvDxNiTSwrrsw9xGgKdNBEZinR5HxgEskriTc0 NjOyMDUxNTYytzRTEuddKPUzWEggPbEkNTs1tSC1KL6oNCe1+BAjEwenVAPjnh6t0o5r+22Z ZHeGx/R3/zj/6kf8/O4Ddsp6U30y14oe7j0jX98Ruq5hIdfSCPZo9hV9/3/sTGOcKihzQm91 ysn6N0mrJzTu/vna+3nWTo+MNa0vkpepxysUdvqv4/kj4HzTs/Dyu7wWt1z7k3cuqVrNYQlu qYyPZLq+r/TCEaszk2Wutb1QYinOSDTUYi4qTgQAxU2BfOoCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42I5/e+xgK5JWnmYwbEGK4v5R86xWvS/Wchq ce7VSkaLy7vmsFnM+TOF2WLRslZmi6XXLzJZ3G5cwWYxYfpaFovWvUfYLc6susXuwO2xZt4a Ro/Lfb1MHg+m/mfyWLn8C5vHplWdbB59W1YxenzeJBfAHtXAaJORmpiSWqSQmpecn5KZl26r 5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDdKWSQlliTilQKCCxuFhJ3w7ThNAQN10L mMYIXd+QILgeIwM0kLCGMWPf036WgmVcFT27L7A1MC7n6GLk4JAQMJHoneXQxcgJZIpJXLi3 nq2LkYtDSGApo8ThO5PZQRK8AoISPybfYwGpZxaQlzhyKRvCVJeYMiUXovwBo8S5n48YIcq1 JF7PP8AGYrMIqEq8/XAULM4GFN//4gYbSK+oQIRE94lKkLCIgIXE3cZFLCBzmAW6mSU+LHkF tlYYKHFy3noWiAUrGSV+rFwDNpRTwEjixokPbBMYBWYhOW8WwnmzEM5bwMi8ilEitSC5oDgp PdcoL7Vcrzgxt7g0L10vOT93EyM4ITyT3sF4eJf7IUYBDkYlHl6PV2VhQqyJZcWVuYcYJTiY lUR4TQPLw4R4UxIrq1KL8uOLSnNSiw8xmgL9N5FZSjQ5H5is8kriDY1NzIwsjcwNLYyMzZXE efddigwTEkhPLEnNTk0tSC2C6WPi4JRqYFzk9oz52pYfHxll2lnXTdL2zIuKOlwS7nxeU5F3 bdcM5ptrK2dp3b1hsqTs5ZXsWZ6c04S3nmEOV9BrPuJa23NcZFEVl+S3eJGkT0Jpu/k+7V/R W/WQXc73RaHLnd3Xix+1vHj6T7658n+tX3F69NSOwKaTMZensPNETqu+2Thxkv/UJcdO1Cmx FGckGmoxFxUnAgBDy0AkHgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2015년 12월 21일 02:15, Sergei Shtylyov wrote: > Hello. > > On 12/20/2015 05:31 PM, Chanwoo Choi wrote: > >> This patch depend on GPIOLIB configuration as following: >> I modified it with following diff and applied it. >> >> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig >> index ba4db7d..3d89e60 100644 >> --- a/drivers/extcon/Kconfig >> +++ b/drivers/extcon/Kconfig >> @@ -54,6 +54,7 @@ config EXTCON_MAX14577 >> >> config EXTCON_MAX3355 >> tristate "Maxim MAX3355 USB OTG EXTCON Support" >> + depends on GPIOLIB || COMPILE_TEST > > If it won't compile w/o gpiolib, what's the use of COMIPLE_TEST? > And no, it shouldn't depend on gpiolib. It has empty stubs for the case of CONFIG_GPIOLIB=n. Obviously something is wrong with the GPIO headers, I'll look into it. Yes. When GPIOLIB is disabled, the build issue don't happen. because include/linux/gpio/consumer.h implement the dummy function for all gpio functions if CONFIG_GPIOLIB is disabled. For correct operation of max3355, you should add the dependency to the extcon-max3355.c driver. This driver use the GPIO library certainly. COMPILE_TEST is used for just build test. You can see the detailed data[1]. [1] https://lkml.org/lkml/2013/5/22/155 Thanks, Chanwoo Choi