From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751441AbbLUCmO (ORCPT <rfc822;w@1wt.eu>);
	Sun, 20 Dec 2015 21:42:14 -0500
Received: from mailout4.samsung.com ([203.254.224.34]:59285 "EHLO
	mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751153AbbLUCmM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 20 Dec 2015 21:42:12 -0500
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
X-AuditID: cbfee68f-f793a6d000001364-d3-56776703f4c9
Content-transfer-encoding: 8BIT
Message-id: <567766FD.2030004@samsung.com>
Date: Mon, 21 Dec 2015 11:42:05 +0900
From: Chanwoo Choi <cw00.choi@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.6.0
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        myungjoo.ham@samsung.com, linux-kernel@vger.kernel.org
Cc: linux-usb@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] extcon: max3355: kill unneeded #include's
References: <6137530.8k1Rzov2Uy@wasted.cogentembedded.com>
In-reply-to: <6137530.8k1Rzov2Uy@wasted.cogentembedded.com>
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmkeLIzCtJLcpLzFFi42JZI2JSrMucXh5mcGUZp8XlXXPYLOb8mcJs
	sWhZK7PF7cYVbBZnVt1id2D1eDD1P5NH35ZVjB6fN8kFMEdx2aSk5mSWpRbp2yVwZUxZeJCt
	4AhXxZJdd5kbGM9zdDFyckgImEgc2XWIFcIWk7hwbz0biC0ksIJRYtkjNpia4+13gGq4gOKz
	GCX6OteBJXgFBCV+TL7H0sXIwcEsIC9x5FI2SJhZQF1i0rxFzBD1DxglNi3axAJRryXxf8oy
	ZhCbRUBVounBbLA5bEDx/S9usIHMERWIkOg+UQkSFhEokvg3o4sRYqa5xLkPs8HuFBawk5jy
	fB7UnVYSa7vXMYO0cgpYS1z4kw6yVkJgG7vE8u1vWSFWCUh8m3wI7EwJAVmJTQeYId6SlDi4
	4gbLBEaxWUiemYXwzCwkzyxgZF7FKJpakFxQnJReZKxXnJhbXJqXrpecn7uJERhHp/8969/B
	ePeA9SFGAQ5GJR5eS/XyMCHWxLLiytxDjKZAR0xklhJNzgdGa15JvKGxmZGFqYmpsZG5pZmS
	OO9CqZ/BQgLpiSWp2ampBalF8UWlOanFhxiZODilGhgjZ1b7vlj5v3trj4rGlMjM7XdM9p0M
	NOaU3HC9te3tv2fLji+bXCcnN9F006Y05gjmGGVl+d0/EhYJbpfZMa1CwvGK/FbGgJ63wUqT
	nufJxGsvrfNTEd/TOilRK1B2mq5rU5qASFQv60FRsysegeerHuR7BasabHQUPOmxN21l1gG+
	/bWPcpRYijMSDbWYi4oTARoAC6KeAgAA
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJIsWRmVeSWpSXmKPExsVy+t9jQV3m9PIwg46XLBaXd81hs5jzZwqz
	xaJlrcwWtxtXsFmcWXWL3YHV48HU/0wefVtWMXp83iQXwBzVwGiTkZqYklqkkJqXnJ+SmZdu
	q+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA7RTSaEsMacUKBSQWFyspG+HaUJoiJuu
	BUxjhK5vSBBcj5EBGkhYw5gxZeFBtoIjXBVLdt1lbmA8z9HFyMkhIWAicbz9DiuELSZx4d56
	ti5GLg4hgVmMEn2d69hAErwCghI/Jt9j6WLk4GAWkJc4cikbJMwsoC4xad4iZoj6B4wSmxZt
	YoGo15L4P2UZM4jNIqAq0fRgNtgcNqD4/hc32EDmiApESHSfqAQJiwgUSfyb0cUIMdNc4tyH
	2WD3CAvYSUx5Pg+sVUjASmJt9zpmkFZOAWuJC3/SJzAC3Yhw3CyE42YhOW4BI/MqRonUguSC
	4qT0XKO81HK94sTc4tK8dL3k/NxNjOBofSa9g/HwLvdDjAIcjEo8vB6vysKEWBPLiitzDzFK
	cDArifCaBpaHCfGmJFZWpRblxxeV5qQWH2I0BfpuIrOUaHI+MJHklcQbGpuYGVkamRtaGBmb
	K4nz7rsUGSYkkJ5YkpqdmlqQWgTTx8TBKdXAmCUrt2rC8sxJ35qebJW7/e5XSvwxme12F875
	XH140vex50VLQyO+zNcR64rXxf65kih35LHTqYIl8UwVHqvU5kid14/7OtN6gat/mluiF5up
	SetRCYWFcvXTziswT5BIEbJa/jM/bOGlypQf23cm2/bZRLzRetgf+33HEpYvLAUzpj/Yfaly
	oxJLcUaioRZzUXEiAKEFNTfsAgAA
DLP-Filter: Pass
X-MTR: 20000000000000000@CPGS
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2015년 12월 21일 03:31, Sergei Shtylyov wrote:
> Some #include's weren't needed from the start, some are left overs from the
> earlier driver versions... Kill 'em all! :-)

I don't prefer following expression. I think you should write the description
to maintain the formal style on the next.
- "... Kill 'em all! :-) "

> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> ---
> The patch is against the 'extcon-next' branch of the 'extcon.git' repo.
> If possible, please fold this patch into the main MAX3355 driver patch.
> 
>  drivers/extcon/extcon-max3355.c |    5 -----
>  1 file changed, 5 deletions(-)
> 
> Index: extcon/drivers/extcon/extcon-max3355.c
> ===================================================================
> --- extcon.orig/drivers/extcon/extcon-max3355.c
> +++ extcon/drivers/extcon/extcon-max3355.c
> @@ -11,14 +11,9 @@
>  
>  #include <linux/extcon.h>
>  #include <linux/gpio.h>
> -#include <linux/init.h>
>  #include <linux/interrupt.h>
> -#include <linux/kernel.h>
>  #include <linux/module.h>
> -#include <linux/of_gpio.h>
>  #include <linux/platform_device.h>
> -#include <linux/slab.h>
> -#include <linux/workqueue.h>
>  
>  struct max3355_data {
>  	struct extcon_dev *edev;
> 

I combine it on original patch.

Thanks,
Chanwoo Choi