From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751394AbbLUJuu (ORCPT ); Mon, 21 Dec 2015 04:50:50 -0500 Received: from mout.web.de ([212.227.17.12]:64088 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030AbbLUJus (ORCPT ); Mon, 21 Dec 2015 04:50:48 -0500 Subject: Re: blackfin-cpufreq: How to mark cpu_set_cclk() as static? To: Viresh Kumar References: <5674598B.6020000@users.sourceforge.net> <20151219015926.GJ3946@ubuntu> <5675141F.2090803@users.sourceforge.net> <20151221031757.GA5532@ubuntu> <5677C452.8040307@users.sourceforge.net> <20151221092805.GD5532@ubuntu> Cc: LKML , linux-pm@vger.kernel.org, "Rafael J. Wysocki" , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <5677CB72.8090504@users.sourceforge.net> Date: Mon, 21 Dec 2015 10:50:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151221092805.GD5532@ubuntu> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:h9INEtFU58qJjX+UKtyj7Ec8v+bnuml1qrn8QqzOL7Ts3Xo2z6S xyFGxjYi5dsAaptfCO/sgzFvAOKwDRj/NSu8mPnU675+3tgEEqv9ujiWORRda2/VjTgm3PT IvbcdYmqReVuCx1l0tRukv0B1FITv4eCP1sySJxghiI52cG7sU9Kr9WyIhwKhW+oMvFRCkx goYwbs7xVGTEj1XIOcFuA== X-UI-Out-Filterresults: notjunk:1;V01:K0:/kRZmygQ2uo=:Z7g3zmi2xPKU4TafoyMriQ mZdeni0ZOGMG6ueepfp1PTBWgiYq+OGIYANvKaI1AHhPU15W8ql2zR1FCVpz2tW2rHa53Miqj v5RDZPKHnCLHmI66sIKi8RI1Zmy0q3wyVev4nyDlErR2iwW3Hyqr3w+NR+2bAPuQQ4/jhjjGW vKESTapfo1NhZyOrI66AecDo0cp2otB7YsXIXiYf5c/9GIhVf537C5Odp6YF3tLvZoNMAnst6 xmGpO4Oh1X+xE1vPnjc7p/45oa7FXFvxjPhdDJc7zKDPVuaKjw8nMZJrfdNFF1HGFWkRLM24R AYJNTaarElRCvW4MhFiSUv1O60ekt9B3psh0/kRUQ4iKRAkYvzdnHKEFqyIqPxxurt7OTBn4l r3AUSWJxuPae+lwpBb/a0ZT9Gpxol1D8CQku8w4ewoiRZxydYfr0YG6R2bt6gaq0GX8+PqWso y1iVrcYT/phvhpyPzumfJiM5GVp85GKkf+Mc0ne85b4YjGD65m6Rnrrhm75KnqOHyOHXU3mYd w/sYRALareyx3GeufcGbrruxBnO7yjosZ9uI62bea33HWZDVAMd8zDyndg1uUovWVbxdZxoNz o0A8pTC/AuwOeeQ0R91a+fLKgS3XQtClSn2CZDmotm9kn6PnFuOwJXngqzZ6MbXV11aXX0VEW GuIjxu7VzqO0yFZNZ725b9JlGPPZDzt0BD8/jUJYmL69YyQ3wmP8xzxvhG3DLymJMTzKvaUn2 DZUawlYw2YsagagHdnHeMwTq1xjfKBSbimKb+l+EdpTD+4ELupxtIdYlhM+xky3cy2tPz4SE5 6LDKApQ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Since you reported the issue, it will be good if you can send a patch > for this as well. I'm sorry if I become a bit picky for this implementation detail. In which order would you prefer that the properties of the function "cpu_set_cclk" will be improved? * Should the linkage specifier be added on a separate source code line? * Can this fix be combined with my previous update suggestion for the return type? Regards, Markus