From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752681AbbLVBNs (ORCPT ); Mon, 21 Dec 2015 20:13:48 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:37719 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751201AbbLVBNp convert rfc822-to-8bit (ORCPT ); Mon, 21 Dec 2015 20:13:45 -0500 X-AuditID: cbfee68e-f793c6d00000136c-29-5678a3c63337 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT Message-id: <5678A3BE.3040701@samsung.com> Date: Tue, 22 Dec 2015 10:13:34 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Sergei Shtylyov Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "myungjoo.ham@samsung.com" , devicetree , linux-kernel , linux-sh@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v5] extcon: add Maxim MAX3355 driver References: <5948633.my3nAG6hRz@wasted.cogentembedded.com> <5676E214.2040009@cogentembedded.com> <5677662C.6060409@samsung.com> <5677DC21.3040509@cogentembedded.com> In-reply-to: <5677DC21.3040509@cogentembedded.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJIsWRmVeSWpSXmKPExsWyRsSkSPfY4oowgwfnFSzmHznHatH/ZiGr xblXKxktLu+aw2Yx588UZotFy1qZLZZev8hkcbtxBZvFhOlrWSxa9x5htziz6ha7A7fHmnlr GD0u9/UyeTyY+p/JY+XyL2wem1Z1snn0bVnF6PF5k1wAexSXTUpqTmZZapG+XQJXxuat39gL LvNXXG45yN7AeJani5GTQ0LAROLRtgcsELaYxIV769m6GLk4hARWMEosf/GOGabo7vmHzBCJ WYwSN+Y3s4EkeAUEJX5MvgfUzcHBLKAuMWVKLkiYWUBEoqENopdZQFti2cLXUL0PGCU+XGlh gejVkrj8+zY7iM0ioCqxZvkvRhCbDSi+/8UNNpCZogIREt0nKkHCIgIWEncbF7GAzGEW6GaW +LDkFVivMFDi5Lz1LBALPjBK7DvyGew4TgEjiVnbboIlJAQaOST+3vrABLFNQOLb5ENgV0sI yEpsOgD1paTEwRU3WCYwis9C8tsshN9mIfltFpLfFjCyrGIUTS1ILihOSi8y0itOzC0uzUvX S87P3cQIjPHT/5717WC8ecD6EKMAB6MSD++LRRVhQqyJZcWVuYcYTYEOmsgsJZqcD0wkeSXx hsZmRhamJqbGRuaWZkrivAlSP4OFBNITS1KzU1MLUovii0pzUosPMTJxcEo1MK6cJlx4ScBv pypj94zouc/sj32WLrQXb3/5c1b0htq5mqsKO5huFiW0iDZ+D9ozIYLZVdNnGvPs49eZj5ly HH6dWvb4iWuz3QKJZN+UtZZ7NFalCrhdvSP64E9Upyrf8xub/AWrdryMnzfXqmVf0s/95R6W /E9+bnEJYcssLrG8W82yreA1txJLcUaioRZzUXEiAGlgOxjsAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphleLIzCtJLcpLzFFi42I5/e+xoO6xxRVhBrfWSFnMP3KO1aL/zUJW i3OvVjJaXN41h81izp8pzBaLlrUyWyy9fpHJ4nbjCjaLCdPXsli07j3CbnFm1S12B26PNfPW MHpc7utl8ngw9T+Tx8rlX9g8Nq3qZPPo27KK0ePzJrkA9qgGRpuM1MSU1CKF1Lzk/JTMvHRb Je/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoCuVFMoSc0qBQgGJxcVK+naYJoSGuOla wDRG6PqGBMH1GBmggYQ1jBmX/h9nLtjJX/GydSFTA+Nmni5GTg4JAROJu+cfMkPYYhIX7q1n 62Lk4hASmMUocWN+MxtIgldAUOLH5HssXYwcHMwC8hJHLmVDmOoSU6bkQpQ/YJT4cKWFBaJc S+Ly79vsIDaLgKrEmuW/GEFsNqD4/hc32EB6RQUiJLpPVIKERQQsJO42LmIBmcMs0M0s8WHJ K7BeYaDEyXnrWSAWfGCU2HfkM9g9nAJGErO23WSZwAh0JcJ5sxDOm4Vw3gJG5lWMEqkFyQXF Sem5Rnmp5XrFibnFpXnpesn5uZsYwSnhmfQOxsO73A8xCnAwKvHwTlhQESbEmlhWXJl7iFGC g1lJhPdKPFCINyWxsiq1KD++qDQntfgQoynQfxOZpUST84HpKq8k3tDYxMzI0sjc0MLI2FxJ nHffpcgwIYH0xJLU7NTUgtQimD4mDk6pBsa0i/6zs+KNVZ4KrvB9NfvlxucfNf+87/TduWvL +pioNp7jv491ynw7ZHmt42csh9UHe5NrS5xTb/GJ34vZFz3JJfTrfzPXdAWBm3u6K57JWazd cHl1bseMK7e6op+/vJV0Pf+CkHfqxa1L0roWmE3oddzXFC/nEq+QUrxRvn2mkCWH4G0mr+tK LMUZiYZazEXFiQBF7+yyHwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 12월 21일 20:01, Sergei Shtylyov wrote: > Hello. > > On 12/21/2015 5:38 AM, Chanwoo Choi wrote: > >>>> This patch depend on GPIOLIB configuration as following: >>>> I modified it with following diff and applied it. >>>> >>>> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig >>>> index ba4db7d..3d89e60 100644 >>>> --- a/drivers/extcon/Kconfig >>>> +++ b/drivers/extcon/Kconfig >>>> @@ -54,6 +54,7 @@ config EXTCON_MAX14577 >>>> >>>> config EXTCON_MAX3355 >>>> tristate "Maxim MAX3355 USB OTG EXTCON Support" >>>> + depends on GPIOLIB || COMPILE_TEST >>> >>> If it won't compile w/o gpiolib, what's the use of COMIPLE_TEST? >>> And no, it shouldn't depend on gpiolib. It has empty stubs for the case of CONFIG_GPIOLIB=n. Obviously something is wrong with the GPIO headers, I'll look into it. >> >> Yes. When GPIOLIB is disabled, the build issue don't happen. > > What? It surely does happen! hmm.... Sure. you need to check the include/linux/gpio/consumer.h. Because of build error happen, you miss to include the "linux/gpio/consumer.h" header file in extcon-max3355.c. Please test it for enough time. > >> because include/linux/gpio/consumer.h implement the dummy function >> for all gpio functions if CONFIG_GPIOLIB is disabled. > > Linus W. advised to #include this header explicitly -- I'll try and post. Don't necessary. I already updated it including the "include/linux/gpio/consumer.h". > >> For correct operation of max3355, you should add the dependency >> to the extcon-max3355.c driver. This driver use the GPIO library >> certainly. > > I disagree. The driver will just cease to load in this case. I don't see why we need such dependency. Only compilation time dependencies should be > specified, I think. This driver have to depend on GPIOLIB. Why are you disagreeing the COMPILE_TEST dependency? It is just compile test without anything.