From: Andy Yan <andy.yan@rock-chips.com>
To: Naoki FUKAUMI <naobsd@gmail.com>
Cc: robh+dt@kernel.org, heiko@sntech.de, arnd@arndb.de,
john.stultz@linaro.org, mark.rutland@arm.com,
geert+renesas@glider.be, catalin.marinas@arm.com,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
alexandre.belloni@free-electrons.com, lorenzo.pieralisi@arm.com,
linux@arm.linux.org.uk, dbaryshkov@gmail.com,
linux-rockchip@lists.infradead.org, joel@jms.id.au,
treding@nvidia.com, wxt@rock-chips.com,
devicetree@vger.kernel.org, khilman@linaro.org,
pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org,
moritz.fischer@ettus.com, gregkh@linuxfoundation.org,
sjg@chromium.org, sre@kernel.org, galak@codeaurora.org,
olof@lixom.net, jun.nie@linaro.org
Subject: Re: [PATCH 5/6] ARM: dts: rockchip: add reboot mode node
Date: Tue, 22 Dec 2015 17:04:42 +0800 [thread overview]
Message-ID: <5679122A.2070700@rock-chips.com> (raw)
In-Reply-To: <CAFnsNoQbeAsuESSPeDDs_fQvPv96pBX=jNh=ahpWrTKLrpEExw@mail.gmail.com>
Hi,
On 2015年12月22日 11:04, Naoki FUKAUMI wrote:
> hi,
>
> On Mon, Dec 21, 2015 at 8:42 PM, Andy Yan<andy.yan@rock-chips.com> wrote:
>> Add reboot mode driver DT node for rk3xxx,rk3288 platform
>>
>> Signed-off-by: Andy Yan<andy.yan@rock-chips.com>
>> ---
>>
>> arch/arm/boot/dts/rk3288.dtsi | 25 +++++++++++++++++++++++
>> arch/arm/boot/dts/rk3xxx.dtsi | 26 ++++++++++++++++++++++++
>> include/dt-bindings/soc/rockchip_boot-mode.h | 30 ++++++++++++++++++++++++++++
>> 3 files changed, 81 insertions(+)
>> create mode 100644 include/dt-bindings/soc/rockchip_boot-mode.h
>>
>> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
>> index 04ea209..937ba4c 100644
>> --- a/arch/arm/boot/dts/rk3288.dtsi
>> +++ b/arch/arm/boot/dts/rk3288.dtsi
>> @@ -170,6 +170,31 @@
>> };
>> };
>>
>> + reboot_mode {
>> + compatible = "rockchip,reboot-mode";
>> + rockchip,regmap = <&pmu>;
>> + offset = <0x94>;
>> + loader {
>> + linux,mode = "loader";
>> + linux,magic = <0x5242C301>;
>> + };
>> +
>> + maskrom {
>> + linux,mode = "maskrom";
>> + linux,magic = <0x5242C302>;
>> + };
>> +
>> + recovery {
>> + linux,mode = "recovery";
>> + linux,magic = <0x5242C303>;
>> + };
>> +
>> + fastboot {
>> + linux,mode = "fastboot";
>> + linux,magic = <0x5242C309>;
>> + };
>> + };
>> +
> (snip)
>
> I sometimes use 0xEF08A53C to load bootloader from SD card instead of
> on-board flash memory such as eMMC.
> https://github.com/linux-rockchip/u-boot-rockchip/blob/u-boot-rk3288/common/cmd_rockusb.c#L893
>
> I don't know any detail about this function.
> (above code says "reboot to maskrom", but it should be wrong from my experience)
>
> do you know something about this function? can you handle this too?
>
> Regards,
>
>
>
Have some discussion with the bootloader engineer, the correct magic
number to
reboot the system to maskrom mode is 0xEF08A53C. I will fix it in
next version.
next prev parent reply other threads:[~2015-12-22 9:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 11:27 [PATCH 0/6] misc: add reboot mode driver Andy Yan
2015-12-21 11:30 ` [PATCH 1/6] dt-bindings: misc: add document for reboot-mode driver Andy Yan
2015-12-21 11:33 ` [PATCH 2/6] dt-bindings: soc: add document for rockchip " Andy Yan
2015-12-21 11:36 ` [PATCH 3/6] misc: add reboot mode driver Andy Yan
2015-12-21 11:39 ` [PATCH 4/6] soc: rockchip: " Andy Yan
2015-12-22 0:59 ` kbuild test robot
2015-12-21 11:42 ` [PATCH 5/6] ARM: dts: rockchip: add reboot mode node Andy Yan
2015-12-22 3:04 ` Naoki FUKAUMI
2015-12-22 9:04 ` Andy Yan [this message]
2015-12-21 11:45 ` [PATCH 6/6] ARM64: " Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5679122A.2070700@rock-chips.com \
--to=andy.yan@rock-chips.com \
--cc=akpm@linux-foundation.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=joel@jms.id.au \
--cc=john.stultz@linaro.org \
--cc=jun.nie@linaro.org \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=moritz.fischer@ettus.com \
--cc=naobsd@gmail.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sjg@chromium.org \
--cc=sre@kernel.org \
--cc=treding@nvidia.com \
--cc=will.deacon@arm.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox