From: Ian Abbott <abbotti@mev.co.uk>
To: maomao xu <albert008.xu@gmail.com>,
hsweeten@visionengravers.com, gregkh@linuxfoundation.org,
colinpatrickcronin@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: fix block comments coding style issue in comedi.h
Date: Tue, 22 Dec 2015 09:13:06 +0000 [thread overview]
Message-ID: <56791422.4050407@mev.co.uk> (raw)
In-Reply-To: <1450762894-5058-1-git-send-email-albert008.xu@gmail.com>
On 22/12/15 05:41, maomao xu wrote:
> Fix up block comments to make a trailing */ on a separate line
>
> Signed-off-by: maomao xu <albert008.xu@gmail.com>
> ---
> drivers/staging/comedi/comedi.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
> index 66edda1..ec5e59c 100644
> --- a/drivers/staging/comedi/comedi.h
> +++ b/drivers/staging/comedi/comedi.h
> @@ -895,7 +895,8 @@ enum amplc_dio_ts_clock_src {
> };
>
> /* Values for setting a gate source with INSN_CONFIG_SET_GATE_SRC for
> - * 8254 counter subdevices on Amplicon DIO boards (amplc_dio200 driver). */
> + * 8254 counter subdevices on Amplicon DIO boards (amplc_dio200 driver).
> + */
> enum amplc_dio_gate_source {
> AMPLC_DIO_GAT_VCC, /* internal high logic level */
> AMPLC_DIO_GAT_GND, /* internal low logic level */
>
Sorry, this clashes with another patch in Greg's staging-next branch.
Also, it doesn't use the preferred block comment style with the leading
'/*' on a separate line.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2015-12-22 9:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 5:41 [PATCH] Staging: comedi: fix block comments coding style issue in comedi.h maomao xu
2015-12-22 9:13 ` Ian Abbott [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-12-14 7:41 maomao xu
2015-12-22 0:02 ` Greg KH
2015-12-23 2:51 ` maoma king
2015-12-23 4:25 ` Sudip Mukherjee
2015-11-18 10:09 maomao xu
[not found] <1447075224-7621-1-git-send-email-albert008.xu@yahoo.com>
2015-11-09 14:48 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56791422.4050407@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=albert008.xu@gmail.com \
--cc=colinpatrickcronin@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox