From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932375AbbLVNpa (ORCPT ); Tue, 22 Dec 2015 08:45:30 -0500 Received: from mout.web.de ([212.227.15.3]:50221 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751693AbbLVNp2 (ORCPT ); Tue, 22 Dec 2015 08:45:28 -0500 Subject: [PATCH v2] ti-st: Use a signed return type for st_ll_sleep_state() To: Dan Carpenter , LKML References: <56758462.1020902@users.sourceforge.net> <20151219201511.GQ5284@mwanda> Cc: kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <567953F0.7000802@users.sourceforge.net> Date: Tue, 22 Dec 2015 14:45:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151219201511.GQ5284@mwanda> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:LzTJRiX78BmeJQ06JKeoyDcfehgeCWwvsnGPWKP+1e49PgqtrbC rqL7t1y/AEEU666nzZOdMaTAe8oLOY3pZp14o4+7WvrE+NbB30GVJ48/SA7U+x+TDRxAYeN ucWJoCqtNtqscb/mvBIRgfpEyPUHN3z3QvlCc2aBuYN9g74glfQlPfcB+beCU5elJzBRTg/ hnS/LfwaCnPJvczkQPqRw== X-UI-Out-Filterresults: notjunk:1;V01:K0:WyjyGVnoX9c=:I5qUUOhQnJpD9l6Z8XXsMt vObaN8IIA8n3IwOvvd30sVc3hUgEVXfT8diTIRak7iRiX3j3wg6ilVYMJ29d2UbqTOis2g2wU tjKjthECJj0C/13VteP6d6H3M4kCBN6zH1YyYzrH+mcpFJLiYNbZbW00XGGvLmbF/rKYmmnHC rf7FuqYz34iQB2fDOKT/Be4kCGinJ0tw+iu6gfoiHU+gKhMlqNe9bYrvyKkvea4+IBaGaJvMn iTFCVNfiNu5Xftpycjzf9UOMiIw7uvW5BK+0AoQgfPfse7qzbhrwQKiHi2JoSYbMKLuBYNhpa 5d/+XFjPAv6ogCvCy2gbcOlZneFLU0EHChb4gETi2TrIj1hiM66rUESscVhPSzxBqcBmNM3ae rvRAts/BVJDUQ9MLuyo5KKCsOCH+3dxCNhzw9m1Wou/is5aqwq0/iLf3Msr9D6v10XcFf/arc NIyrj2fsOM5CClpcesAl5R28xCze1l2Enxvzbv2NzOqXnx/I1rtv8ICGTybHxIn5YL3PPkVDf VpcczaKheyIXogoUSAoMF6Rjd3kHTRnD1eMXoqS8T7RfbPk88qFZ1jbAizh6x7e999wdJrbnT pvQKIYwzDoxmH3lH8RKQZzjmlsJlwl7nFZaxVXnh4MsdHgUAMI42ZZVBtlUisYybMoyPj6P+A LPXMWckwtL0VGvuuYwC7gGn8nB0sLeGn/8j/1QRTBEiKlF5WhTJ3k3z4XYTMsQBjgd/SzbKEq KEW/jqhinKRvaF87WF6qSywQTLVo8N9lU+SZAwTq3ifWpTTQgF/1HT05RDMJtIXSBeeSOiYXz hc+Xk0/ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 22 Dec 2015 14:40:47 +0100 The return type "unsigned long" was used by the st_ll_sleep_state() function even though it will eventually return a negative error code. Improve this implementation detail by using the type "int" instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/misc/ti-st/st_ll.c | 2 +- include/linux/ti_wilink_st.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/ti-st/st_ll.c b/drivers/misc/ti-st/st_ll.c index 93b4d67..788d436 100644 --- a/drivers/misc/ti-st/st_ll.c +++ b/drivers/misc/ti-st/st_ll.c @@ -128,7 +128,7 @@ unsigned long st_ll_getstate(struct st_data_s *ll) } /* called from ST Core, when a PM related packet arrives */ -unsigned long st_ll_sleep_state(struct st_data_s *st_data, +int st_ll_sleep_state(struct st_data_s *st_data, unsigned char cmd) { switch (cmd) { diff --git a/include/linux/ti_wilink_st.h b/include/linux/ti_wilink_st.h index 0a0d568..4205eb2 100644 --- a/include/linux/ti_wilink_st.h +++ b/include/linux/ti_wilink_st.h @@ -391,7 +391,7 @@ void st_ll_disable(struct st_data_s *); * of the chip. */ unsigned long st_ll_getstate(struct st_data_s *); -unsigned long st_ll_sleep_state(struct st_data_s *, unsigned char); +int st_ll_sleep_state(struct st_data_s *, unsigned char); void st_ll_wakeup(struct st_data_s *); /* -- 2.6.3