From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754417AbbLVOMt (ORCPT ); Tue, 22 Dec 2015 09:12:49 -0500 Received: from mout.web.de ([212.227.15.4]:50748 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752914AbbLVOMr (ORCPT ); Tue, 22 Dec 2015 09:12:47 -0500 Subject: [PATCH v2] staging-slicoss: Use a signed return type for slic_card_locate() To: Christopher Harrer , Dan Carpenter , Greg Kroah-Hartman , Lior Dotan , devel@driverdev.osuosl.org References: <5675B207.2010706@users.sourceforge.net> <20151219201955.GS5284@mwanda> Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML From: SF Markus Elfring Message-ID: <56795A50.9070300@users.sourceforge.net> Date: Tue, 22 Dec 2015 15:12:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151219201955.GS5284@mwanda> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:dJerq1DSl3L4ERFnPN4a0+6L9Z0gSkbOUgCx73J4V/cRD6uaQXY 7pU0nEYajxmVl5mt3iGPCMTBLqTfmHQry0r08PX9ODSOJvziE65mlHOI428TLVrVk0wJahf uoLMnvQauSGkXgfS+Of3yY8ouCbZOkvGZ/rnAbJMDjQbkwt/kY4mKd6Hze/AMEx+UpgRo3C 9aIXH8Mc1ajp4tZfkcnwg== X-UI-Out-Filterresults: notjunk:1;V01:K0:DvNd6mKOjKw=:tSkfhp853J3VsSMS1uNLlt G254MVXZxgoZTityAELcEBfMjWYxoXWQq6vtg8j0BB1/mORfjTLerxBbqZSlXTOr8BEsDhEQT zWbcP+6QAmN065gLByOht8/tY0cx64V/BbKGi6r85gUG5a2cLV3y8+D1X0ty0qyYxU+OQLMy8 s7Yg+viRHdrFPtRc55baGKhw1POv1OAL+zg3lPIt/vbykUDv4rN3IK3mARWRqj1SEhzulkn4f Po3i2j3xojcCsJLHU+dMZEe4UPlGgfKOJ/RtwNtt3nYsPbDk9G5katYL7kD4sW7hBG0azP5Xd MDVqUIeFeKVTmCGUL9TvKTFrhTt2VPP5AP3BaopzR658KXWoKWVQhLRAQsrucMDS92ZT5AKRp Q2txq0saGo5wKbyhNDEyKzQjZTKJWYD804u+dDNKyllD7MySDJO74DFPn3cP8j/wvMMeLsYS8 WXvVjVzJvbap2sDNOynyZh32CMUlN/csgqO+/j67xKhH9YjB6sEsIie47XXO2cUOYcNDEXEBT GL0995hLfTZQFA7AJNidgpGYcr3s6pzxW/rEfkUI2edTg8TvvOCCc1HtupnEx3OKNclAwti0y eZVyZDGB60Fd0zgcJwo1a+SSsBl+mm11f30USCzPllTRcrI24ACsSE3brRlsDCFVKJVbUTTdx 4KQwG6aGavHTPAhGHiuk7DmytEqXrqpzxmhoVkalJdzsmbzXQCmGfbDrjqwRisfSVvg/0TblH CfGBjiWyWjURsaiTh/i9qEm3heFCe2KxQut1eMQ364FTJ+1cCHQXFrs8UBl2mww+b+yxDKRte pgxJ0Qy Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 22 Dec 2015 15:05:16 +0100 The return type "u32" was used by the slic_card_locate() function even though it will eventually return a negative error code. Improve this implementation detail by using the type "int" instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/slicoss/slicoss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index b23a2d1..156e57f 100644 --- a/drivers/staging/slicoss/slicoss.c +++ b/drivers/staging/slicoss/slicoss.c @@ -2953,7 +2953,7 @@ static const struct net_device_ops slic_netdev_ops = { .ndo_change_mtu = eth_change_mtu, }; -static u32 slic_card_locate(struct adapter *adapter) +static int slic_card_locate(struct adapter *adapter) { struct sliccard *card = slic_global.slic_card; struct physcard *physcard = slic_global.phys_card; -- 2.6.3