From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755356AbbLVPwE (ORCPT ); Tue, 22 Dec 2015 10:52:04 -0500 Received: from mout.web.de ([212.227.15.4]:57740 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752028AbbLVPwB (ORCPT ); Tue, 22 Dec 2015 10:52:01 -0500 Subject: [PATCH v2 1/2] USB-FHCI: Use a signed return type for fhci_create_ep() To: linux-usb@vger.kernel.org, Dan Carpenter , Greg Kroah-Hartman References: <5675BAE0.2010304@users.sourceforge.net> <20151219202706.GT5284@mwanda> <567970D1.3030503@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <5679718E.9050104@users.sourceforge.net> Date: Tue, 22 Dec 2015 16:51:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <567970D1.3030503@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:MErZ6xfFlGBGb9qyoJfE2fdxQ+S9Ubm/1MRZZ0LHQGt6/B8SWhd 2xU+YQwiIBsOj3icAlq37JrMWiz3M7v3it2ZmGFdslQ6XCeN9EiDmO27mtfE4XdWwpF2LVA 6YyvsKdeJGDwnWs7JFG2S4Bf+tJOMYhc32vBD4PGxpUbjHgweBMDb+HKaASejIjLgoypggE YWzBJdEhX5gk7h0tnxqhw== X-UI-Out-Filterresults: notjunk:1;V01:K0:njuxivvOWzY=:79ZfYLIA7ILhmbBilEYeSB DYqWvMvCL0OfXnws2Dr+QHTdmi7KxsDadyWnROw1V+PMK0bwawjYzolzkkaFKOZYYnqa1UNMI RBUcykYWM4DyUNWo0jbkmpFRQ6VDlJG7pgMaAAw1zyTXoAcEkYDtYsV6Gp4i0Fu4XTTB8yPkb 3wfmfItcEQIsV6rujb8y6/O7njFEtOfJS3RbJRXawPQeDVskPoYvViJ0wDMYdg/2M31NKwvGm 1DHIiJZ9Kmxn/pxa2Ho+tfmGgEu61/TPJzh8K5mHhUIo1fu/gUY+4VouqxM645fwletslNZhg I+bmcARmELCfq7VcxB7RPW990D1Ts1lLGN9dP5RdJQcudQjfwBWa6P50aylLN2oX5zcl/uP5R VzQk8ipqPTnEon4NlY5yZNQZAxYDkf0kHWzOPY8BJ00SBoIy6aDoyLZ+j5hhqI8wlFcQmHZ7Z SpHRPVg0OJubbEZlEOw/EUPp7IIGNLb7wq0u/NmD7FJ9hxRhtM5fMbdztaK8ObqDWABiolL78 yOo1Cwew0rS+GlSBjrb1cI0328H9Gy5cbUc/CJtZbrB0IArt5FEJrGyMbbuczuUWWYQq2TaYt BDLW1TOJFosB6ivLneUeG+Y5O4avyi+Hofu1u7JOg9xCAXe5k19WFgsdZNKSNAPHVaVE59Mzi DpzAhmzm17E8wSWlDCkyf/O9/5bTUCD0j9enLQDf8ABHEUzTl34FAPgXv7DqNaQILoE3SZkLH 4Z162Ko5Blv4UcFWsflCk1KsMLW4DDlgZJ6uSTPQ+Xg1yO2DSDHaoyxj/qBSVvNUSzF6t/cNd PtFxJna Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 22 Dec 2015 16:10:14 +0100 The return type "u32" was used by the fhci_create_ep() function even though it will eventually return a negative error code. Improve this implementation detail by using the type "int" instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/usb/host/fhci-tds.c | 2 +- drivers/usb/host/fhci.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/fhci-tds.c b/drivers/usb/host/fhci-tds.c index f82ad5d..fc0b525 100644 --- a/drivers/usb/host/fhci-tds.c +++ b/drivers/usb/host/fhci-tds.c @@ -149,7 +149,7 @@ void fhci_ep0_free(struct fhci_usb *usb) * data_mem The data memory partition(BUS) * ring_len TD ring length */ -u32 fhci_create_ep(struct fhci_usb *usb, enum fhci_mem_alloc data_mem, +int fhci_create_ep(struct fhci_usb *usb, enum fhci_mem_alloc data_mem, u32 ring_len) { struct endpoint *ep; diff --git a/drivers/usb/host/fhci.h b/drivers/usb/host/fhci.h index 154e6a0..afa3cfc 100644 --- a/drivers/usb/host/fhci.h +++ b/drivers/usb/host/fhci.h @@ -547,7 +547,7 @@ u32 fhci_host_transaction(struct fhci_usb *usb, struct packet *pkt, void fhci_host_transmit_actual_frame(struct fhci_usb *usb); void fhci_tx_conf_interrupt(struct fhci_usb *usb); void fhci_push_dummy_bd(struct endpoint *ep); -u32 fhci_create_ep(struct fhci_usb *usb, enum fhci_mem_alloc data_mem, +int fhci_create_ep(struct fhci_usb *usb, enum fhci_mem_alloc data_mem, u32 ring_len); void fhci_init_ep_registers(struct fhci_usb *usb, struct endpoint *ep, -- 2.6.3