From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755378AbbLVPyl (ORCPT ); Tue, 22 Dec 2015 10:54:41 -0500 Received: from mout.web.de ([212.227.15.14]:53539 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752825AbbLVPyj (ORCPT ); Tue, 22 Dec 2015 10:54:39 -0500 Subject: [PATCH v2 2/2] USB-FHCI: Use a signed return type for endpoint_zero_init() To: linux-usb@vger.kernel.org, Dan Carpenter , Greg Kroah-Hartman References: <5675BAE0.2010304@users.sourceforge.net> <20151219202706.GT5284@mwanda> <567970D1.3030503@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <56797232.1020501@users.sourceforge.net> Date: Tue, 22 Dec 2015 16:54:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <567970D1.3030503@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:WoqUskwo/BzplZy9y6ZXH9BExVz4mZBuj18JDGkUIelhAFVy81n CjZz/CxvDwIUQ0WCbwwQzDiqZwKguI10rgOT/K4prOB+M9PW5kxPFY1wG6IX5266UT14rS4 KxVjyRPV1GwfU90YuBZryNnSjrshTynA6U+4+xu0UiM5AG3UAfKLsx6CI772yCgwUzRR36C PUdQr5NGaPopj8a0ObTOw== X-UI-Out-Filterresults: notjunk:1;V01:K0:tp4srMxRgs4=:2gWQ4CSKSRsrr5uRkU1rYQ Skgezv62Dm1kIg1XPD7xshcXtMa+cjKk/uoTKwVCr3kzuPKPbP05BFG/YNQpVbTgc8l/C18QR esnbFy7RDlw6ObLRvdJigc+191Qhp7Tjt7CJDOTMF2jn6yr4AWkYtfmlMppTYwEAg51BTAhee FsHFwmO3ru7BDhGQa7MoqTGHh222ZW3TFbOtRHF+LnoxN2gxpsV6gz6PyLjJvNfvRGkby/P0k N3z8ne0/M1ReCQ1RwnBl+sUeJ8vZoHZZH4FHUCvlXRqTR+cCnih9+0ofGjYpBH1XyviOEONrJ EA6PoYprcNed2JiH8tlQAV8GLuZZTKzpM+6YjI+Tn5pS8xXu5tqaStvbul+clY8362dXL5Bmj 2cGWP82v30lDf4zL3j50BifeHbEJqZvTGQFc1P0Y+B/92Q2uhTPfmvORMRu1CEseBVfqTJegm VpEjd8HmVHx0x7+G0qiEptX+QEcjGtLE/dorO8gmyf8JkBXyH5ZHJiVhwCOlCM2GK9Fls6vDt KOOQtASjnE2qXUaqB9PhvT71q11f54O1vI+Ob76JzCABYxszefELZRX4+Gk70keIkjUrbRVBg QYOyeOg6vDjYgvr7PC6dCFSOaxa2Frd65U/Gk4yU4eVnMFNPJRREtn/j3tC7bAPt4Q7cYA/7m BKcxjlH9QUVsvNjTunUFzrjvz7AoYB4NxoBjNbl+W1glBlKA75iuAEgKPGSFj3DDqnIavXW+f DjAKdsyhPOp9Wcj702xOYNLiNEkzwlJ6Op3SRgVWk+EwzueYJI5X7ck/G8RW81nNo6KtV5MVg 9TACdzv Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 22 Dec 2015 16:24:46 +0100 The return type "u32" was used by the endpoint_zero_init() function even though it can return a value which corresponds to a negative error code from a call of the fhci_create_ep() function. Improve this implementation detail by using the type "int" instead. Signed-off-by: Markus Elfring --- drivers/usb/host/fhci-hcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c index c6cebb9..b2889f0 100644 --- a/drivers/usb/host/fhci-hcd.c +++ b/drivers/usb/host/fhci-hcd.c @@ -64,11 +64,11 @@ u16 fhci_get_sof_timer_count(struct fhci_usb *usb) } /* initialize the endpoint zero */ -static u32 endpoint_zero_init(struct fhci_usb *usb, +static int endpoint_zero_init(struct fhci_usb *usb, enum fhci_mem_alloc data_mem, u32 ring_len) { - u32 rc; + int rc; rc = fhci_create_ep(usb, data_mem, ring_len); if (rc) -- 2.6.3