From: Jens Axboe <axboe@fb.com>
To: Junichi Nomura <j-nomura@ce.jp.nec.com>,
Kent Overstreet <kent.overstreet@gmail.com>,
Tejun Heo <tj@kernel.org>
Cc: "Artem S. Tashkinov" <t.artem@lycos.com>,
"Artem S. Tashkinov" <t.artem@mailcity.com>,
Christoph Hellwig <hch@lst.de>, Ming Lin <ming.l@ssi.samsung.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Steven Whitehouse <swhiteho@redhat.com>,
IDE-ML <linux-ide@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ming Lei <tom.leiming@gmail.com>
Subject: Re: IO errors after "block: remove bio_get_nr_vecs()"
Date: Tue, 22 Dec 2015 10:28:06 -0700 [thread overview]
Message-ID: <56798826.6000908@fb.com> (raw)
In-Reply-To: <20151222052611.GA10487@xzibit.linux.bs1.fc.nec.co.jp>
On 12/21/2015 10:26 PM, Junichi Nomura wrote:
> On 12/22/15 12:59, Kent Overstreet wrote:
>> reproduced it with 32 bit pae:
>>
>>> 1. Exclude memory above 4G line with boot param "max_addr=4G".
>>
>> doesn't work - max_addr=1G doesn't work either
>>
>>> 2. Disable highmem with "highmem=0".
>>
>> works!
>>
>>> 3. Try booting 64bit kernel.
>>
>> works
>
> blk_queue_bio() does split then bounce, which makes the segment
> counting based on pages before bouncing and could go wrong.
Good catch! The blk-mq parts aren't affected by this, the screw up only
happened in the old IO path. I've added this with the appropriate
tested-by from Artem, and CC stable and listed the commit that broke it:
commit 54efd50bfd873e2dbf784e0b21a8027ba4299a3e
Author: Kent Overstreet <kent.overstreet@gmail.com>
Date: Thu Apr 23 22:37:18 2015 -0700
block: make generic_make_request handle arbitrarily sized bios
Thanks to all involved in nailing this down, it'll go out shortly.
--
Jens Axboe
next prev parent reply other threads:[~2015-12-22 17:28 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-20 17:51 IO errors after "block: remove bio_get_nr_vecs()" Linus Torvalds
2015-12-20 18:18 ` Christoph Hellwig
2015-12-20 18:41 ` Linus Torvalds
2015-12-20 23:36 ` Artem S. Tashkinov
2015-12-21 11:21 ` Dan Aloni
2015-12-20 18:44 ` Kent Overstreet
2015-12-20 23:41 ` Artem S. Tashkinov
2015-12-20 23:25 ` Artem S. Tashkinov
2015-12-20 23:42 ` Kent Overstreet
2015-12-20 23:49 ` Artem S. Tashkinov
2015-12-20 23:23 ` Artem S. Tashkinov
2015-12-21 1:38 ` Ming Lei
2015-12-21 1:50 ` Artem S. Tashkinov
2015-12-21 2:18 ` Ming Lei
2015-12-21 2:25 ` Artem S. Tashkinov
2015-12-21 2:32 ` Kent Overstreet
2015-12-21 3:21 ` Ming Lei
2015-12-21 3:36 ` Artem S. Tashkinov
2015-12-21 4:32 ` Linus Torvalds
2015-12-21 4:43 ` Artem S. Tashkinov
2015-12-21 4:47 ` Linus Torvalds
2015-12-21 5:23 ` Linus Torvalds
2015-12-21 7:31 ` Artem S. Tashkinov
2015-12-22 4:06 ` Artem S. Tashkinov
2015-12-21 4:26 ` Tejun Heo
2015-12-21 5:10 ` Linus Torvalds
2015-12-21 6:55 ` Tejun Heo
2015-12-21 7:25 ` Artem S. Tashkinov
2015-12-21 19:35 ` Tejun Heo
2015-12-21 20:07 ` Tejun Heo
2015-12-21 21:08 ` Tejun Heo
2015-12-22 3:43 ` Kent Overstreet
2015-12-22 3:59 ` Kent Overstreet
2015-12-22 5:26 ` Junichi Nomura
2015-12-22 5:37 ` Kent Overstreet
2015-12-22 5:38 ` Kent Overstreet
2015-12-22 5:52 ` Artem S. Tashkinov
2015-12-22 5:55 ` Kent Overstreet
2015-12-22 5:59 ` Artem S. Tashkinov
2015-12-22 6:02 ` Kent Overstreet
2015-12-22 17:28 ` Jens Axboe [this message]
2015-12-22 4:45 ` Kent Overstreet
2015-12-22 5:10 ` Artem S. Tashkinov
2015-12-22 5:20 ` Artem S. Tashkinov
2015-12-21 22:51 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56798826.6000908@fb.com \
--to=axboe@fb.com \
--cc=hch@lst.de \
--cc=j-nomura@ce.jp.nec.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.l@ssi.samsung.com \
--cc=swhiteho@redhat.com \
--cc=t.artem@lycos.com \
--cc=t.artem@mailcity.com \
--cc=tj@kernel.org \
--cc=tom.leiming@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox