From: Sasha Levin <sasha.levin@oracle.com>
To: Petko Manolov <petkan@mip-labs.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: dmitry.kasatkin@gmail.com, james.l.morris@oracle.com,
serge@hallyn.com, linux-ima-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IMA: policy can be updated zero times
Date: Tue, 22 Dec 2015 16:50:01 -0500 [thread overview]
Message-ID: <5679C589.1060102@oracle.com> (raw)
In-Reply-To: <31A92AAB-5516-4176-A947-128CB65B6931@mip-labs.com>
On 12/22/2015 04:40 PM, Petko Manolov wrote:
>> Thanks, Sasha. By the time ima_update_policy() is called
>> >ima_release_policy() has already output the policy update status
>> >message. I guess an empty policy could be considered a valid policy.
>> >Could you add a msg indicating that the new policy was empty?
>
> As far as I can say we can't get to ima_update_policy() with empty ima_temp_rules because ima_write_policy() will set valid_policy to 0 in case of an empty rule. I'll double check it tomorrow, but please you do that too.
This is based on an actual crash rather than code analysis.
Thanks,
Sasha
next prev parent reply other threads:[~2015-12-22 21:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 13:51 [PATCH] IMA: policy can be updated zero times Sasha Levin
2015-12-22 19:56 ` Mimi Zohar
2015-12-22 21:40 ` Petko Manolov
2015-12-22 21:50 ` Sasha Levin [this message]
2015-12-23 11:47 ` Petko Manolov
2015-12-23 12:24 ` Mimi Zohar
2015-12-23 12:47 ` [Linux-ima-devel] " Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5679C589.1060102@oracle.com \
--to=sasha.levin@oracle.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=james.l.morris@oracle.com \
--cc=linux-ima-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=petkan@mip-labs.com \
--cc=serge@hallyn.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox