Re: [PATCH] um: Fix build error and kconfig for i386

Mickaël Salaün
2015-12-23T12:57:41Z

[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]

On 22/12/2015 23:28, Richard Weinberger wrote:
> Am 22.12.2015 um 22:44 schrieb Mickaël Salaün:
>> Fix build error by selecting COREDUMP when X86_32 is selected:
>>
>> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
>> (.text+0x3e62): undefined reference to `dump_emit'
>> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
>> (.text+0x3eef): undefined reference to `dump_emit'
>>
>> Signed-off-by: Mickaël Salaün <mic@digikod.net>
>> Cc: Jeff Dike <jdike@addtoit.com>
>> Cc: Richard Weinberger <richard@nod.at>
>> ---
>> arch/x86/um/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/x86/um/Kconfig b/arch/x86/um/Kconfig
>> index ed56a1c4ae73..bb7cd8b38043 100644
>> --- a/arch/x86/um/Kconfig
>> +++ b/arch/x86/um/Kconfig
>> @@ -26,6 +26,7 @@ config X86_32
>> select CLONE_BACKWARDS
>> select OLD_SIGSUSPEND3
>> select OLD_SIGACTION
>> + select COREDUMP
>
>
> Do you know since when this is broken?

After some bisecting, it's broken since v3.15. I'll send a new patch including this info.

Mickaël

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]