From: Guenter Roeck <linux@roeck-us.net>
To: Tomas Winkler <tomasw@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Wim Van Sebroeck <wim@iguana.be>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux Watchdog Mailing List <linux-watchdog@vger.kernel.org>,
Damien Riegel <damien.riegel@savoirfairelinux.com>,
Pratyush Anand <panand@redhat.com>
Subject: Re: [PATCH 2/5] watchdog: Separate and maintain variables based on variable lifetime
Date: Tue, 22 Dec 2015 16:32:51 -0800 [thread overview]
Message-ID: <5679EBB3.2000707@roeck-us.net> (raw)
In-Reply-To: <CA+i0qc6O9BJaJd-RrZhoTRUkkCohTjZxVccS=NC6JEUKYwvGPQ@mail.gmail.com>
On 12/22/2015 02:05 PM, Tomas Winkler wrote:
>
> > Do you see a situation where holding the lock between calls into the driver
> > might be a problem ?
>
> I don't think u are holding the lock now in watchdog_unregister when WDOG_UNREGISTERED was dropped.
the lock is held while clearing the pointers:
mutex_lock(&wd_data->lock);
wd_data->wdd = NULL;
wdd->wd_data = NULL;
mutex_unlock(&wd_data->lock);
Guenter
next prev parent reply other threads:[~2015-12-23 0:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-20 21:04 [PATCH 0/5] watchdog: Replace driver based refcounting Guenter Roeck
2015-12-20 21:04 ` [PATCH 1/5] watchdog: Create watchdog device in watchdog_dev.c Guenter Roeck
2015-12-21 17:31 ` Damien Riegel
2015-12-21 23:28 ` Guenter Roeck
2015-12-22 15:33 ` Damien Riegel
2015-12-22 16:15 ` Guenter Roeck
2015-12-20 21:05 ` [PATCH 2/5] watchdog: Separate and maintain variables based on variable lifetime Guenter Roeck
2015-12-21 17:28 ` Damien Riegel
2015-12-21 23:36 ` Tomas Winkler
2015-12-22 1:40 ` Guenter Roeck
[not found] ` <CA+i0qc6O9BJaJd-RrZhoTRUkkCohTjZxVccS=NC6JEUKYwvGPQ@mail.gmail.com>
2015-12-23 0:32 ` Guenter Roeck [this message]
2015-12-22 1:10 ` Guenter Roeck
2015-12-22 16:09 ` Damien Riegel
2015-12-22 16:22 ` Guenter Roeck
2015-12-22 19:28 ` Damien Riegel
2015-12-22 19:34 ` Guenter Roeck
2015-12-20 21:05 ` [PATCH 3/5] watchdog: da9052_wdt: Drop reference counting Guenter Roeck
2015-12-20 21:05 ` [PATCH 4/5] watchdog: da9055_wdt: " Guenter Roeck
2015-12-20 21:05 ` [PATCH 5/5] hwmon: (sch56xx) Drop watchdog driver data reference count callbacks Guenter Roeck
2015-12-21 10:37 ` Hans de Goede
2015-12-21 13:21 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5679EBB3.2000707@roeck-us.net \
--to=linux@roeck-us.net \
--cc=damien.riegel@savoirfairelinux.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=panand@redhat.com \
--cc=tomasw@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox