From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754955AbbLWCSN (ORCPT ); Tue, 22 Dec 2015 21:18:13 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:44374 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752078AbbLWCSK (ORCPT ); Tue, 22 Dec 2015 21:18:10 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68f-f793a6d000001364-72-567a04606f37 Content-transfer-encoding: 8BIT Message-id: <567A0456.7090400@samsung.com> Date: Wed, 23 Dec 2015 11:17:58 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Sergei Shtylyov Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "myungjoo.ham@samsung.com" , devicetree , linux-kernel , linux-sh@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v5] extcon: add Maxim MAX3355 driver References: <5948633.my3nAG6hRz@wasted.cogentembedded.com> <5676E214.2040009@cogentembedded.com> <5677662C.6060409@samsung.com> <5677DC21.3040509@cogentembedded.com> <5678A3BE.3040701@samsung.com> <567930C3.3090600@cogentembedded.com> In-reply-to: <567930C3.3090600@cogentembedded.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsWyRsSkSDeBpSrMYOUWLov5R86xWvS/Wchq ce7VSkaLy7vmsFnM+TOF2WLRslZmi6XXLzJZ3G5cwWYxYfpaFovWvUfYLc6susXuwO2xZt4a Ro/Lfb1MHg+m/mfyWLn8C5vHplWdbB59W1YxenzeJBfAHsVlk5Kak1mWWqRvl8CVcXdWC2vB ZZGK9tbv7A2MhwS6GDk5JARMJE7NmskCYYtJXLi3nq2LkYtDSGAFo0T3p10sMEV/l8xihUjM AkosucUIkuAVEJT4MfkeUBEHB7OAvMSRS9kQprrElCm5EOUPGCUmb1/LClGuJXH35H82EJtF QFXixdvXYDYbUHz/ixtsIL2iAhES3ScqQcIiAhYSdxsXsYDMYRboZpb4sOQVO0hCGChxct56 FogF25kkFk+5DnYop4CRxJaWrYwgCQmBv+wSaz70sENsE5D4NvkQ2KESArISmw4wQzwmKXFw xQ2WCYxis5C8MwvhnVkI7yxgZF7FKJpakFxQnJReZKxXnJhbXJqXrpecn7uJERivp/8969/B ePeA9SFGAQ5GJR5eh7bKMCHWxLLiytxDjKZAN0xklhJNzgcmhbySeENjMyMLUxNTYyNzSzMl cd6FUj+DhQTSE0tSs1NTC1KL4otKc1KLDzEycXBKNTBuuVfl8M/0xcFGXsdupzOftF537sg9 dfC9u/0E60PPxf+mfvmi6r1vVdijnd92ZquH/P2zqfaxuN75BR9DtjsV1G7sXFXEGuOVnn5p 9a+eU/zyof4nxDg4Hk6eafciaLF74h+HubZNUWlvKtrC1hZunhWmXmPzv1bhjI/L0x+Bv8p/ urxlD9FXYinOSDTUYi4qTgQAxAdGE9ICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphleLIzCtJLcpLzFFi42I5/e+xoG4CS1WYwfoZLBbzj5xjteh/s5DV 4tyrlYwWl3fNYbOY82cKs8WiZa3MFkuvX2SyuN24gs1iwvS1LBate4+wW5xZdYvdgdtjzbw1 jB6X+3qZPB5M/c/ksXL5FzaPTas62Tz6tqxi9Pi8SS6APaqB0SYjNTEltUghNS85PyUzL91W yTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH6EolhbLEnFKgUEBicbGSvh2mCaEhbroW MI0Rur4hQXA9RgZoIGENY8bdWS2sBZdFKtpbv7M3MB4S6GLk5JAQMJH4u2QWK4QtJnHh3nq2 LkYuDiGBWYwS3UtuMYIkeAUEJX5MvsfSxcjBwSwgL3HkUjaEqS4xZUouRPkDRonJ29eyQpRr Sdw9+Z8NxGYRUJV48fY1mM0GFN//4gYbSK+oQIRE94lKkLCIgIXE3cZFLCBzmAW6mSU+LHnF DpIQBkqcnLeeBWLBdiaJxVOus4AkOAWMJLa0bGWcwAh0JcJ5sxDOm4Vw3gJG5lWMEqkFyQXF Sem5hnmp5XrFibnFpXnpesn5uZsYwSnhmdQOxoO73A8xCnAwKvHwOrRVhgmxJpYVV+YeYpTg YFYS4U1/BxTiTUmsrEotyo8vKs1JLT7EaAr030RmKdHkfGC6yiuJNzQ2MTOyNDI3tDAyNlcS 5629FBkmJJCeWJKanZpakFoE08fEwSnVwNjLFbRBJyXrmLTF1NPLvc+LX7wYkLBB+IHs+r1e TffrSsX1ggTsmS7eWsAx1VnJ4NcdhjmaSavf6LbVN6k+Chbpl71efVttWfV/iZm9k89HsSnc cpyVdK2R5XPkoflcB5s54kQuMZi4ZNVwN64WavFzbnB9eHl9R9R04f1/txtmFHqvWT/5qxJL cUaioRZzUXEiAAVCAJwfAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 12월 22일 20:15, Sergei Shtylyov wrote: > Hello. > > On 12/22/2015 4:13 AM, Chanwoo Choi wrote: > >>>>>> This patch depend on GPIOLIB configuration as following: >>>>>> I modified it with following diff and applied it. >>>>>> >>>>>> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig >>>>>> index ba4db7d..3d89e60 100644 >>>>>> --- a/drivers/extcon/Kconfig >>>>>> +++ b/drivers/extcon/Kconfig >>>>>> @@ -54,6 +54,7 @@ config EXTCON_MAX14577 >>>>>> >>>>>> config EXTCON_MAX3355 >>>>>> tristate "Maxim MAX3355 USB OTG EXTCON Support" >>>>>> + depends on GPIOLIB || COMPILE_TEST >>>>> >>>>> If it won't compile w/o gpiolib, what's the use of COMIPLE_TEST? >>>>> And no, it shouldn't depend on gpiolib. It has empty stubs for the case of CONFIG_GPIOLIB=n. Obviously something is wrong with the GPIO headers, I'll look into it. >>>> >>>> Yes. When GPIOLIB is disabled, the build issue don't happen. >>> >>> What? It surely does happen! >> >> hmm.... >> Sure. you need to check the include/linux/gpio/consumer.h. >> >> Because of build error happen, you miss to include the "linux/gpio/consumer.h" >> header file in extcon-max3355.c. Please test it for enough time. > > Yes, with this file #include'd, it build fine now. > >>>> because include/linux/gpio/consumer.h implement the dummy function >>>> for all gpio functions if CONFIG_GPIOLIB is disabled. >>> >>> Linus W. advised to #include this header explicitly -- I'll try and post. >> >> Don't necessary. I already updated it including the "include/linux/gpio/consumer.h". > > I saw that, yes. > >>>> For correct operation of max3355, you should add the dependency >>>> to the extcon-max3355.c driver. This driver use the GPIO library >>>> certainly. >>> >>> I disagree. The driver will just cease to load in this case. I don't see why we need such dependency. Only compilation time dependencies should be >>> specified, I think. >> >> This driver have to depend on GPIOLIB. >> Why are you disagreeing the COMPILE_TEST dependency? It is just compile test >> without anything. > > I agree now. I still disagree about the gpiolib dependency though. If gpiolib is disabled, extcon-max3355.c might not operate it correctly. Just this driver could be built without operation because gpiolib function will not do the any behavior. I think that it is not too much problem. I should send the pull request within this week. If you want to need more discussion of extcon-max3355.c, I will not include it on pull request for v4.5 because there is issue.