From: Andy Yan <andy.yan@rock-chips.com>
To: Rob Herring <robh@kernel.org>
Cc: heiko@sntech.de, arnd@arndb.de, john.stultz@linaro.org,
sjg@chromium.org, alexandre.belloni@free-electrons.com,
treding@nvidia.com, galak@codeaurora.org,
ijc+devicetree@hellion.org.uk, wxt@rock-chips.com,
catalin.marinas@arm.com, olof@lixom.net, geert+renesas@glider.be,
linux-rockchip@lists.infradead.org, dbaryshkov@gmail.com,
sre@kernel.org, jun.nie@linaro.org, pawel.moll@arm.com,
will.deacon@arm.com, akpm@linux-foundation.org,
devicetree@vger.kernel.org, linux@arm.linux.org.uk,
gregkh@linuxfoundation.org, joel@jms.id.au,
linux-arm-kernel@lists.infradead.org, lorenzo.pieralisi@arm.com,
khilman@linaro.org, moritz.fischer@ettus.com,
linux-kernel@vger.kernel.org, mark.rutland@arm.com
Subject: Re: [PATCH v1 1/6] dt-bindings: misc: add document for reboot-mode driver
Date: Wed, 23 Dec 2015 17:01:37 +0800 [thread overview]
Message-ID: <567A62F1.1040505@rock-chips.com> (raw)
In-Reply-To: <20151223003217.GA18700@rob-hp-laptop>
Hi Rob:
On 2015年12月23日 08:32, Rob Herring wrote:
> On Tue, Dec 22, 2015 at 05:05:24PM +0800, Andy Yan wrote:
>> add device tree bindings document for reboot-mode driver
>>
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>>
>> ---
>>
>> Changes in v1: None
>>
>> .../devicetree/bindings/misc/reboot-mode.txt | 41 ++++++++++++++++++++++
>> 1 file changed, 41 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/misc/reboot-mode.txt
>>
>> diff --git a/Documentation/devicetree/bindings/misc/reboot-mode.txt b/Documentation/devicetree/bindings/misc/reboot-mode.txt
>> new file mode 100644
>> index 0000000..082bc0c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/misc/reboot-mode.txt
>> @@ -0,0 +1,41 @@
>> +Generic reboot mode communication driver
> You're not describing a driver. It is a mapping of boot modes to values.
>> +
>> +This driver get reboot mode arguments from userspace
> Coming from userspace is a Linuxism.
>
>> +and stores it in special register or ram . Then the
>> +bootloader will read it and take different action
>> +according the argument stored.
>> +
>> +Required properties:
>> + - compatible = "reboot-mode" or other vendor compatible string;
>> +
>> +Each mode is represented as a sub-node of reboot_mode:
>> +
>> +Subnode required properties:
>> + - linux,mode: reboot mode command,such as "loader","recovery", "fastboot".
>> + - linux,magic: magic number for the mode, this is vendor specific.
>> +
>> +example:
>> + reboot_mode {
>> + compatible = "rockchip,reboot-mode";
>> + rockchip,regmap = <&pmu>;
>> + offset = <0x40>;
>> + loader {
>> + linux,mode = "loader";
>> + linux,magic = <0x5242C301>;
>> + };
> These can be much more simply expressed as:
>
> loader = <0x5242c301>;
how about :
loader,magic= <0x5242c301>; ?
>
> I would like to see the property names here standardized as much as
> possible. I'm not sure if we can define the properties as a u32 or need
> some flexibility here.
>
> Rob
>
>
>
next prev parent reply other threads:[~2015-12-23 9:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 9:02 [PATCH v1 0/6] misc: add reboot mode driver Andy Yan
2015-12-22 9:05 ` [PATCH v1 1/6] dt-bindings: misc: add document for reboot-mode driver Andy Yan
2015-12-23 0:32 ` Rob Herring
2015-12-23 8:37 ` Moritz Fischer
2015-12-23 9:01 ` Andy Yan [this message]
2015-12-22 9:08 ` [PATCH v1 2/6] dt-bindings: soc: add document for rockchip " Andy Yan
2015-12-22 9:10 ` [PATCH v1 3/6] misc: add reboot mode driver Andy Yan
2015-12-22 9:13 ` [PATCH v1 4/6] soc: rockchip: " Andy Yan
2015-12-22 9:16 ` [PATCH v1 5/6] ARM: dts: rockchip: add reboot-mode node Andy Yan
2015-12-22 11:23 ` Heiko Stübner
2015-12-22 9:19 ` [PATCH v1 6/6] ARM64: " Andy Yan
2015-12-22 16:47 ` [PATCH v1 0/6] misc: add reboot mode driver Alexandre Belloni
2015-12-23 9:31 ` Andy Yan
2015-12-28 15:28 ` Arnd Bergmann
2015-12-28 15:56 ` Heiko Stübner
2015-12-28 16:09 ` Arnd Bergmann
2015-12-29 7:55 ` Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567A62F1.1040505@rock-chips.com \
--to=andy.yan@rock-chips.com \
--cc=akpm@linux-foundation.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=joel@jms.id.au \
--cc=john.stultz@linaro.org \
--cc=jun.nie@linaro.org \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=moritz.fischer@ettus.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
--cc=sjg@chromium.org \
--cc=sre@kernel.org \
--cc=treding@nvidia.com \
--cc=will.deacon@arm.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox