From: Felipe Ferreri Tonello <eu@felipetonello.com>
To: Felipe Balbi <balbi@ti.com>, linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Robert Baldyga <r.baldyga@samsung.com>,
Clemens Ladisch <clemens@ladisch.de>
Subject: Re: [PATCH 1/2] usb: gadget: f_midi: refactor state machine
Date: Wed, 23 Dec 2015 09:19:58 +0000 [thread overview]
Message-ID: <567A673E.2020708@felipetonello.com> (raw)
In-Reply-To: <87egeepe5p.fsf@saruman.tx.rr.com>
[-- Attachment #1: Type: text/plain, Size: 1536 bytes --]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hi Balbi,
On 22/12/15 17:49, Felipe Balbi wrote:
>
> Hi,
>
> "Felipe F. Tonello" <eu@felipetonello.com> writes:
>> This refactor includes the following: * Cleaner state machine
>> code; * Reset state if MIDI message parsed is non-conformant; *
>> Fixed bug when a conformant MIDI message was followed by a
>> non-conformant causing the MIDI-USB message to use old temporary
>> data (port->data[0..1]), thus packing a wrong MIDI-USB request.
>
> we don't do more than one logical thing per patch. Please split
> this up.
Actually this patch has only one logical change, the state machine
refactoring. But by doing it, those three items were a consequence.
Felipe
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCAAGBQJWemc+AAoJEMxEtNCSaY5qpXwP/1B/sVsfapRtP4dw93YF6En5
w/ej9JatIyJIaXNxauCVzgRl9uuiXGyEqErRjJdodyvHar3yKvD9HEXE6MhowEp4
JMD/phN2v9Sdj1VxRf9Z0XDSWsg6huVhfQU47HBMRGiY8ezvEgir2bvg7dYbZMsv
ACgIx8oh6N/AEHPq9GoLbEpXfJ58Pl564Sq/2o6wWsJQS06A+jp+JmqK4Y3eB5M5
18rmLW7lQLcZPO08Pf/c6BExWQLbzY/mT8KofwycvC9hWxYp9LPwJY4oMzOWROe8
AZS1ayRqlabG3qx3dPRcV4j6c6uROEfQY+HejCn+Zbi0CfVYtsI+xO5LkwnZMUyc
0qvy90h0PUQ2e37/wo5YnnVLK0ce1Gm6gY50iFXwqE69m55KHTufsIVX4eTUBfcj
PtugPtTnKEsW171r/gHPYO9A+WKxycCvjPs9Wogsljly+NrRzgPMAI7Alx//4lwq
QhwRWF1BkNOoCPEpHnVlLkcIhgdcAbbnvWxlcAVlLAQ/oYl6ShbQFv96y/2IWCVO
Mwr7Ab8a/dnyJ/GWEQdpJUmfKGQbKNpM93H5yD4AQlmz4Hj620gzm3y2XNJY2bUt
8H37Q2VWtlcRy2UHjgBSeF0YKCvdDuDmZwRZbPpajkmbcYSGtJFDve1/L6bOtZSj
7nVfYIqvtIBWrDZ3PF9G
=3uC5
-----END PGP SIGNATURE-----
[-- Attachment #2: 0x92698E6A.asc --]
[-- Type: application/pgp-keys, Size: 7195 bytes --]
[-- Attachment #3: 0x92698E6A.asc.sig --]
[-- Type: application/pgp-signature, Size: 543 bytes --]
prev parent reply other threads:[~2015-12-23 9:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 16:08 [PATCH 1/2] usb: gadget: f_midi: refactor state machine Felipe F. Tonello
2015-12-22 16:08 ` [PATCH 2/2] usb: gadget: f_midi: added spinlock on transmit function Felipe F. Tonello
2015-12-25 8:03 ` Peter Chen
2015-12-22 17:10 ` [PATCH 1/2] usb: gadget: f_midi: refactor state machine Clemens Ladisch
2015-12-23 11:50 ` Felipe Ferreri Tonello
2015-12-23 21:46 ` Clemens Ladisch
2015-12-22 17:49 ` Felipe Balbi
2015-12-23 9:19 ` Felipe Ferreri Tonello [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567A673E.2020708@felipetonello.com \
--to=eu@felipetonello.com \
--cc=balbi@ti.com \
--cc=clemens@ladisch.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=r.baldyga@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox