From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752988AbbLWPC2 (ORCPT ); Wed, 23 Dec 2015 10:02:28 -0500 Received: from mga09.intel.com ([134.134.136.24]:38204 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbbLWPCY (ORCPT ); Wed, 23 Dec 2015 10:02:24 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,469,1444719600"; d="scan'208";a="868285009" Subject: Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to the akcipher api To: Herbert Xu References: <20151223143352.5035.85876.stgit@tstruk-mobl1> <20151223145130.GA2598@gondor.apana.org.au> Cc: linux-kernel@vger.kernel.org, dhowells@redhat.com, linux-security-module@vger.kernel.org, linux-crypto@vger.kernel.org, zohar@linux.vnet.ibm.com From: Tadeusz Struk Message-ID: <567AB6AF.4040702@intel.com> Date: Wed, 23 Dec 2015 06:58:55 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151223145130.GA2598@gondor.apana.org.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/23/2015 06:51 AM, Herbert Xu wrote: >> > Changes in v4: >> > - Flatten both patches into one to avoid bisect compilation problems. > Why is this necessary? Because the first patch modifies the struct public_key and removes the MPIs from it, which the code modified in the second patch still uses. If bisect only takes the first then the build will fail on the security/integrity/digsig_asymmetric.c as reported by kbuild test robot: >> security/integrity/digsig_asymmetric.c:95:5: error: 'struct public_key_signature' has no member named 'nr_mpi' pks.nr_mpi = 1; Thanks, -- TS