From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965285AbbLWSkI (ORCPT <rfc822;w@1wt.eu>);
	Wed, 23 Dec 2015 13:40:08 -0500
Received: from a.ns.miles-group.at ([95.130.255.143]:11949 "EHLO radon.swed.at"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S934002AbbLWSkE (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 23 Dec 2015 13:40:04 -0500
Subject: Re: [PATCH v2] um: Fix pointer cast
To: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= <mic@digikod.net>,
        linux-kernel@vger.kernel.org
References: <1450876627-4814-1-git-send-email-mic@digikod.net>
Cc: Jeff Dike <jdike@addtoit.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        user-mode-linux-devel@lists.sourceforge.net,
        Al Viro <viro@ZenIV.linux.org.uk>
From: Richard Weinberger <richard@nod.at>
Message-ID: <567AEA7E.2090207@nod.at>
Date: Wed, 23 Dec 2015 19:39:58 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <1450876627-4814-1-git-send-email-mic@digikod.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 23.12.2015 um 14:17 schrieb Mickaël Salaün:
> Fix a pointer cast typo introduced in v4.4-rc5 especially visible for
> the i386 subarchitecture where it results in a kernel crash.
> 
> Fixes: 8090bfd2bb9a ("um: Fix fpstate handling")
> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> Cc: Jeff Dike <jdike@addtoit.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Al Viro <viro@ZenIV.linux.org.uk>
> ---
>  arch/x86/um/signal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/um/signal.c b/arch/x86/um/signal.c
> index e5f854ce2d72..14fcd01ed992 100644
> --- a/arch/x86/um/signal.c
> +++ b/arch/x86/um/signal.c
> @@ -470,7 +470,7 @@ long sys_sigreturn(void)
>  	struct sigcontext __user *sc = &frame->sc;
>  	int sig_size = (_NSIG_WORDS - 1) * sizeof(unsigned long);
>  
> -	if (copy_from_user(&set.sig[0], (void *)sc->oldmask, sizeof(set.sig[0])) ||
> +	if (copy_from_user(&set.sig[0], &sc->oldmask, sizeof(set.sig[0])) ||
>  	    copy_from_user(&set.sig[1], frame->extramask, sig_size))
>  		goto segfault;

FYI Linus already merged your patch. :-)
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=de3793796f78e293cc0873744a75588c99ed2fdd

Thanks,
//richard