Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node

Mark Brown
2015-12-22T16:08:49Z

[-- Attachment #1: Type: text/plain, Size: 662 bytes --]

On Mon, Dec 21, 2015 at 11:01:37AM +0800, chenfeng wrote:

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns. Doing this makes your messages much
easier to read and reply to.

> I see, I will change the table of voltages into driver.
> like this,
> static const unsigned int voltages[] = {
> 1500000, 1800000, 2400000, 2500000,
> 2600000, 2700000, 2850000, 3000000,
> };

> And there will be two open-code function for is-enable and disable in the regulator driver.
> Since we need use the status and disable register on PM chip. Only enable reg in the regulator desc.

> Do you agree with this?

Yes.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]