Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node

chenfeng
2015-12-24T02:51:02Z

On 2015/12/23 8:46, Mark Brown wrote:
> On Mon, Dec 21, 2015 at 02:20:16PM +0800, chenfeng wrote:
>
> Please fix your mail client to word wrap within paragraphs at something
> substantially less than 80 columns. Doing this makes your messages much
> easier to read and reply to.
>
ok, thanks for your advice.
>> While doing this in driver code, I found that it seems all the vendor
>> chip have the voltage table. So I am wondering can we add this into
>> the regulator framework.
>
>> We can add in the function of_get_regulation_constraints to get the
>> vset table.
>
>> I am not sure this is right or not.
>
> I'm just not convinced it's a good pattern to move this data out to DT,
> like I said in my other mail it's making the ABI bigger and I'm not sure
> I see much upside over putting the data in a table in DT rather than in
> C code. It's more parsing code and more things we really shouldn't
> change in future.
>
ok. I will send the new version soon.