From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932270AbbLXCxV (ORCPT <rfc822;w@1wt.eu>);
	Wed, 23 Dec 2015 21:53:21 -0500
Received: from devils.ext.ti.com ([198.47.26.153]:52326 "EHLO
	devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752327AbbLXCxT (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 23 Dec 2015 21:53:19 -0500
Subject: Re: [PATCH 2/2] power:bq27xxx: fix register numbers of bq27500
To: "H. Nikolaus Schaller" <hns@goldelico.com>,
        =?UTF-8?Q?Pali_Roh=c3=a1r?= <pali.rohar@gmail.com>,
        Sebastian Reichel <sre@kernel.org>,
        Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>
References: <cover.1450347172.git.hns@goldelico.com>
 <dd1c67a7c8a2cabed0433f2d7b30f91bb0b06b78.1450347172.git.hns@goldelico.com>
CC: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <gta04-owner@goldelico.com>, <marek@goldelico.com>
From: "Andrew F. Davis" <afd@ti.com>
Message-ID: <567B5DEC.3050106@ti.com>
Date: Wed, 23 Dec 2015 20:52:28 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <dd1c67a7c8a2cabed0433f2d7b30f91bb0b06b78.1450347172.git.hns@goldelico.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/17/2015 04:12 AM, H. Nikolaus Schaller wrote:
> bug: according to data sheet some register numbers are wrong.
>
> tested: no
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>

Indeed they are, good catch.

Acked-by: Andrew F. Davis <afd@ti.com>

> ---
>   drivers/power/bq27xxx_battery.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
> index e54a125..f9a5f4f 100644
> --- a/drivers/power/bq27xxx_battery.c
> +++ b/drivers/power/bq27xxx_battery.c
> @@ -198,10 +198,10 @@ static u8 bq27500_regs[] = {
>   	INVALID_REG_ADDR,	/* TTECP - NA	*/
>   	0x0c,	/* NAC		*/
>   	0x12,	/* LMD(FCC)	*/
> -	0x1e,	/* CYCT		*/
> +	0x2a,	/* CYCT		*/
>   	INVALID_REG_ADDR,	/* AE - NA	*/
> -	0x20,	/* SOC(RSOC)	*/
> -	0x2e,	/* DCAP(ILMD)	*/
> +	0x2c,	/* SOC(RSOC)	*/
> +	0x3c,	/* DCAP(ILMD)	*/
>   	INVALID_REG_ADDR,	/* AP - NA	*/
>   };
>
>