From: Guenter Roeck <linux@roeck-us.net>
To: Damien Riegel <damien.riegel@savoirfairelinux.com>
Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers
Date: Thu, 24 Dec 2015 07:25:59 -0800 [thread overview]
Message-ID: <567C0E87.7020007@roeck-us.net> (raw)
In-Reply-To: <20151224150744.GA6463@localhost>
On 12/24/2015 07:07 AM, Damien Riegel wrote:
> On Wed, Dec 23, 2015 at 09:11:28PM -0800, Guenter Roeck wrote:
>> The 'dev' variable in watchdog drivers has a different lifetime than the
>> watchdog character device and should therefore not be used by watchdog
>> drivers.
>>
>> Some of the drivers use the variable to print kernel messages. Those are
>> either dropped or converted to use pr_ functions. One driver sets the
>> variable during initialization to the watchdog driver's parent device,
>> which is wrong and also removed.
>
> Hi Guenter,
>
> For gpio_wdt and mena21_wdt, wdd->parent is set and could be used for
> dev_* printings. Do you prefer to keep this variable only for watchdog
> core internal usage? Otherwise, the serie looks good.
>
Good idea, I'll use ->parent for those. ->parent is set by the driver,
so it is safe to be used by the driver.
Thanks,
Guenter
prev parent reply other threads:[~2015-12-24 15:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 5:11 [PATCH 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers Guenter Roeck
2015-12-24 5:11 ` [PATCH 1/5] watchdog: bcm2835_wdt: Drop log message if watchdog is stopped Guenter Roeck
2015-12-24 5:11 ` [PATCH 2/5] watchdog: tangox: Print info message using pointer to platform device Guenter Roeck
2015-12-24 5:11 ` [PATCH 3/5] watchdog: gpio: Do not use device pointer from struct watchdog_device Guenter Roeck
2015-12-24 5:11 ` [PATCH 4/5] watchdog: mena21: " Guenter Roeck
2015-12-24 5:11 ` [PATCH 5/5] watchdog: qcom-wdt: Do not set 'dev' in " Guenter Roeck
2015-12-24 15:07 ` [PATCH 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers Damien Riegel
2015-12-24 15:25 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567C0E87.7020007@roeck-us.net \
--to=linux@roeck-us.net \
--cc=damien.riegel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox