From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752256AbbLZT7L (ORCPT ); Sat, 26 Dec 2015 14:59:11 -0500 Received: from mail-lb0-f176.google.com ([209.85.217.176]:35269 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633AbbLZT7I (ORCPT ); Sat, 26 Dec 2015 14:59:08 -0500 Subject: Re: [PATCH] coccinelle: api: check for propagation of error from platform_get_irq To: Julia Lawall , Gilles Muller , Nicolas Palix , Michal Marek , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org References: <1451157891-24881-1-git-send-email-Julia.Lawall@lip6.fr> Cc: kernel-janitors@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <567EF188.7020203@cogentembedded.com> Date: Sat, 26 Dec 2015 22:59:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1451157891-24881-1-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/26/2015 10:24 PM, Julia Lawall wrote: > The error return value of platform_get_irq seems to often get dropped. Maybe it was intentional (see my recent follow-up to your netdev patch). But if an error gets unconditionally overriden, deferred probing can't work. So your patches seem good things in the end. Thank you! > Signed-off-by: Julia Lawall [...] MBR, Sergei