Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq

Julia Lawall
2015-12-27T11:41:41Z

[-- Attachment #1: Type: TEXT/PLAIN, Size: 833 bytes --]

On Sun, 27 Dec 2015, SF Markus Elfring wrote:

> > The error return value of platform_get_irq seems to often get dropped.
>
> How do you think about any more fine-tuning here?
>
> Commit message:
> * … of the platform_get_irq() function seems to get dropped too often.
>
> * Why do you concentrate on a single function name?
> Do you plan to extend this source code analysis approach?
>
>
> > +@script:python r_report depends on report@
> > +j0 << r.j0;
> > +j1 << r.j1;
> > +@@
> > +
> > +msg = "Propagate return value of platform_get_irq around line %s." % (j1[0].line)
>
> Are there more unchecked return values which are interesting
> for further considerations?
> https://cwe.mitre.org/data/definitions/252.html

The value is not unchecked. I made a specific rule because the specific
problem is quite common.

julia