Re: [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq

Sergei Shtylyov
2015-12-27T11:18:53Z

On 12/27/2015 9:13 AM, Julia Lawall wrote:

>> Well, looking again, the patch should be good. I just thought its goal was
>> to fix the code as well...
>
> I could do that for the irq < 0 case, but I think that in that case, kbuild
> will only run the patch version, and the <= cases will not be reported on.
> I don't have a general fix for the <= 0. Is it even correct to have < in
> some cases and <= in others?

That's a good question...
In my prior fixes of this case I preferred to consider IRQ0 valid and so
used 'irq < 0'. I myself don't share the "IRQ0 is invalid" sentiment...

> julia

MBR, Sergei