From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753891AbbL0H6y (ORCPT <rfc822;w@1wt.eu>);
	Sun, 27 Dec 2015 02:58:54 -0500
Received: from mout.web.de ([212.227.15.3]:63241 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751175AbbL0H6u (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 27 Dec 2015 02:58:50 -0500
Subject: Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of
 error from platform_get_irq
To: Julia Lawall <julia.lawall@lip6.fr>
References: <1451157891-24881-1-git-send-email-Julia.Lawall@lip6.fr>
 <567EF188.7020203@cogentembedded.com>
 <alpine.DEB.2.02.1512262107340.2070@localhost6.localdomain6>
 <alpine.DEB.2.02.1512262123500.2070@localhost6.localdomain6>
 <567EF895.6080702@cogentembedded.com>
 <alpine.DEB.2.02.1512262156580.2070@localhost6.localdomain6>
Cc: Coccinelle <cocci@systeme.lip6.fr>, LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org, linux-media@vger.kernel.org,
        netdev@vger.kernel.org, linux-i2c@vger.kernel.org,
        linux-spi@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Gilles Muller <Gilles.Muller@lip6.fr>, Michal Marek <mmarek@suse.com>,
        Nicolas Palix <nicolas.palix@imag.fr>,
        Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <567F9A29.50202@users.sourceforge.net>
Date: Sun, 27 Dec 2015 08:58:33 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.02.1512262156580.2070@localhost6.localdomain6>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:SHtpIOg/yuXz7Xe3iiwfzeK5kcZP2U9zL/1qv+9IW4P87bFjFpQ
 +YkBdJ/Fzft20V1Yn6+oIQhxlVItzaXoGa1Fozpm6WY6IV3A9M6VQVNJL9ivNhxhFVNWzbO
 hZjaNLMYhL/am7Oa3mvQdDq0lSb+a/2584rsPwkbCe7scu2Rttfe/glN/LHM+Ao7rBjGnfn
 6vuNr+KoBPVMYluFpfPvg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:7+5IGvxDyDI=:DKVYUNN19a+M8ZSU2GRK4f
 3NDIXF/WYRM1lEgehrhLeVP+orWSfbioKqI/aaPyIsSG/gfQIvldhonuZAC77FA+GVW2E54Y8
 Ecx47S0TW4hAVLdsc5ek/jUJ5cfix5sXHB6b/+FJw54UBJ4iRkKUOcMJtYL3z3l1KVZKRwzb+
 XJ2/QywGIDmNDC15JvFq31pNjs5pdve6iZo5LaIFfJofYkUXdzAmqD0SJz/A7kqoezCf/9I7l
 bGTiy4a60JtbyxroHdn1pjk1oHCftS51HyK63e4oZe18lpdXIDvAj1WqrAKfd/l48FLLWfkES
 mfTKIGdIuW2Qw8z+vlkOZlIwD3AaJbyd5T7gy4RZ2EHewrtbAkaiWC+4jPzA4T0z9QufaVxpx
 uHrk6qRjjOdHyOwT40A0++bi1Ho/FpfSjPXcuLppK9etqXRlXIN5kqMG1SKv0Vgoi8W1bpoPz
 qKrsHastqKKtslLldveQmHM5P+9UbwEbq4Wd1nc0qBBQj5sM2YpWOdFabt16NE8eHcCl8yHd9
 jo9ZmIuyqrRetwbbLmo63F9A5sDV4xFdl2UAdsZ9xspoGIWpdFet1V1idOkah1eM3CO0o7BVo
 Qfkp8yT5AcmEatMCZA3d4YBnPjFik1kBaMMxmEKwZE/xdBvtXVcQEVIEJQmBTAv2vCKvKaARg
 v1lGtDuIXJCKVVe076ltaD4lzlK2N4RzLR4FlQbHNoYVX9+ArGdIrHOdFNnN4PSBlv0sOO5/N
 7CwNr0bUsHJAiig2gepkoOc+CXZer1nxys6dDXOkjJJBsayTOWySEOzD1zSWS6Z1o5WtdsyGk
 mK/z235
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> The error return value of platform_get_irq seems to often get dropped.

How do you think about any more fine-tuning here?

Commit message:
* … of the platform_get_irq() function seems to get dropped too often.

* Why do you concentrate on a single function name?
  Do you plan to extend this source code analysis approach?


> +@script:python r_report depends on report@
> +j0 << r.j0;
> +j1 << r.j1;
> +@@
> +
> +msg = "Propagate return value of platform_get_irq around line %s." % (j1[0].line)

Are there more unchecked return values which are interesting
for further considerations?
https://cwe.mitre.org/data/definitions/252.html

Regards,
Markus