public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Buonopane <paul@earth2me.com>
To: linux-kernel@vger.kernel.org
Subject: ideapad_laptop: Fix for backlight regression
Date: Sun, 27 Dec 2015 04:27:54 -0500	[thread overview]
Message-ID: <567FAF1A.7030200@earth2me.com> (raw)

26bff5f099722fa7c38796a3ccd0e880cf1a524a introduced a regression in 
ideapad_laptop (https://bugzilla.kernel.org/show_bug.cgi?id=110021).  
I've created a quick fix as a pull request: 
https://github.com/torvalds/linux/pull/236  Here's the patch, for 
convenience:

*** drivers/platform/x86/ideapad-laptop.c.old    2015-12-27 
03:48:36.243613843 -0500
--- drivers/platform/x86/ideapad-laptop.c    2015-12-27 
03:49:28.310280733 -0500
*************** static int ideapad_acpi_add(struct platf
*** 933,939 ****
       ideapad_sync_rfk_state(priv);
       ideapad_sync_touchpad_state(priv);

!     if (acpi_video_get_backlight_type() == acpi_backlight_vendor) {
           ret = ideapad_backlight_init(priv);
           if (ret && ret != -ENODEV)
               goto backlight_failed;
--- 933,939 ----
       ideapad_sync_rfk_state(priv);
       ideapad_sync_touchpad_state(priv);

!     if (acpi_video_get_backlight_type() != acpi_backlight_vendor) {
           ret = ideapad_backlight_init(priv);
           if (ret && ret != -ENODEV)
               goto backlight_failed;

I've tested the patch on a Yoga 900 running 4.3.3 x86_64 with a few 
other compatibility patches.  Backlight controls work perfectly with it 
applied.

                 reply	other threads:[~2015-12-27  9:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=567FAF1A.7030200@earth2me.com \
    --to=paul@earth2me.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox