From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754635AbbL0J2I (ORCPT ); Sun, 27 Dec 2015 04:28:08 -0500 Received: from mail-qk0-f174.google.com ([209.85.220.174]:35846 "EHLO mail-qk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754586AbbL0J17 (ORCPT ); Sun, 27 Dec 2015 04:27:59 -0500 To: linux-kernel@vger.kernel.org From: Paul Buonopane Subject: ideapad_laptop: Fix for backlight regression Message-ID: <567FAF1A.7030200@earth2me.com> Date: Sun, 27 Dec 2015 04:27:54 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 26bff5f099722fa7c38796a3ccd0e880cf1a524a introduced a regression in ideapad_laptop (https://bugzilla.kernel.org/show_bug.cgi?id=110021). I've created a quick fix as a pull request: https://github.com/torvalds/linux/pull/236 Here's the patch, for convenience: *** drivers/platform/x86/ideapad-laptop.c.old 2015-12-27 03:48:36.243613843 -0500 --- drivers/platform/x86/ideapad-laptop.c 2015-12-27 03:49:28.310280733 -0500 *************** static int ideapad_acpi_add(struct platf *** 933,939 **** ideapad_sync_rfk_state(priv); ideapad_sync_touchpad_state(priv); ! if (acpi_video_get_backlight_type() == acpi_backlight_vendor) { ret = ideapad_backlight_init(priv); if (ret && ret != -ENODEV) goto backlight_failed; --- 933,939 ---- ideapad_sync_rfk_state(priv); ideapad_sync_touchpad_state(priv); ! if (acpi_video_get_backlight_type() != acpi_backlight_vendor) { ret = ideapad_backlight_init(priv); if (ret && ret != -ENODEV) goto backlight_failed; I've tested the patch on a Yoga 900 running 4.3.3 x86_64 with a few other compatibility patches. Backlight controls work perfectly with it applied.